Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1189603003: Remove RenderSizedBox. (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove RenderSizedBox. Make old users of RenderSizedBox use RenderConstrainedBox. Change the semantics of BoxDecoration.apply* to actually apply the provided constraints to the current constraints, rather than the previous behaviour of merging them neutrally. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/27e8777ad4c69b7dcd4e06b5f787e08a2adab2d4

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -99 lines) Patch
M sky/examples/rendering/borders.dart View 5 chunks +10 lines, -10 lines 0 comments Download
M sky/examples/rendering/transform.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M sky/sdk/lib/rendering/box.dart View 5 chunks +33 lines, -68 lines 0 comments Download
M sky/sdk/lib/rendering/object.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/basic.dart View 3 chunks +24 lines, -10 lines 1 comment Download
M sky/tests/framework/stocks-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/raw/box_layout.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/raw/render_box.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M sky/tests/raw/render_box-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm https://codereview.chromium.org/1189603003/diff/1/sky/sdk/lib/widgets/basic.dart File sky/sdk/lib/widgets/basic.dart (right): https://codereview.chromium.org/1189603003/diff/1/sky/sdk/lib/widgets/basic.dart#newcode159 sky/sdk/lib/widgets/basic.dart:159: BoxConstraints _getConstraints() { BoxConstraints get _additionalConstraints { ...
5 years, 6 months ago (2015-06-15 22:50:56 UTC) #2
Hixie
5 years, 6 months ago (2015-06-15 22:52:00 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
27e8777ad4c69b7dcd4e06b5f787e08a2adab2d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698