chrome/browser/ui/sync/one_click_signin_helper.cc - Issue 11896021: Change the one-click sign in confirmation bubble into a modal dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 11896021: Change the one-click sign in confirmation bubble into a modal dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebased Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/sync/one_click_signin_helper.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc

index 94b91165afb33be5e03ecd6b9d9a8ef18a73a1f7..b6436b7a095e442130e5167c2619897bb0abd38a 100644

--- a/chrome/browser/ui/sync/one_click_signin_helper.cc

+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc

@@ -350,6 +350,7 @@ bool OneClickInfoBarDelegateImpl::Accept() {

RecordHistogramAction(one_click_signin::HISTOGRAM_ACCEPTED);

chrome::FindBrowserWithWebContents(web_contents)->window()->

ShowOneClickSigninBubble(

+ BrowserWindow::ONE_CLICK_SIGNIN_BUBBLE_TYPE_BUBBLE,

base::Bind(&StartSync, browser,

OneClickSigninHelper::AUTO_ACCEPT_NONE, session_index_,

email_, password_));

@@ -904,6 +905,7 @@ void OneClickSigninHelper::DidStopLoading(

case AUTO_ACCEPT_ACCEPTED:

SigninManager::DisableOneClickSignIn(profile);

browser->window()->ShowOneClickSigninBubble(

+ BrowserWindow::ONE_CLICK_SIGNIN_BUBBLE_TYPE_MODAL_DIALOG,

base::Bind(&StartSync, browser, auto_accept_, session_index_,

email_, password_));

break;