Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 11896021: Change the one-click sign in confirmation bubble into a modal dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/frame/browser_view.h" 5 #include "chrome/browser/ui/views/frame/browser_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/auto_reset.h" 9 #include "base/auto_reset.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 1102 matching lines...) Expand 10 before | Expand all | Expand 10 after
1113 void BrowserView::ShowBookmarkPrompt() { 1113 void BrowserView::ShowBookmarkPrompt() {
1114 GetLocationBarView()->ShowBookmarkPrompt(); 1114 GetLocationBarView()->ShowBookmarkPrompt();
1115 } 1115 }
1116 1116
1117 void BrowserView::ShowChromeToMobileBubble() { 1117 void BrowserView::ShowChromeToMobileBubble() {
1118 GetLocationBarView()->ShowChromeToMobileBubble(); 1118 GetLocationBarView()->ShowChromeToMobileBubble();
1119 } 1119 }
1120 1120
1121 #if defined(ENABLE_ONE_CLICK_SIGNIN) 1121 #if defined(ENABLE_ONE_CLICK_SIGNIN)
1122 void BrowserView::ShowOneClickSigninBubble( 1122 void BrowserView::ShowOneClickSigninBubble(
1123 OneClickSigninBubbleType type,
1123 const StartSyncCallback& start_sync_callback) { 1124 const StartSyncCallback& start_sync_callback) {
1124 OneClickSigninBubbleView::ShowBubble(toolbar_->app_menu(), 1125 OneClickSigninBubbleView::ShowBubble(type, toolbar_, start_sync_callback);
1125 start_sync_callback);
1126 } 1126 }
1127 #endif 1127 #endif
1128 1128
1129 void BrowserView::SetDownloadShelfVisible(bool visible) { 1129 void BrowserView::SetDownloadShelfVisible(bool visible) {
1130 // This can be called from the superclass destructor, when it destroys our 1130 // This can be called from the superclass destructor, when it destroys our
1131 // child views. At that point, browser_ is already gone. 1131 // child views. At that point, browser_ is already gone.
1132 if (browser_ == NULL) 1132 if (browser_ == NULL)
1133 return; 1133 return;
1134 1134
1135 if (visible && IsDownloadShelfVisible() != visible) { 1135 if (visible && IsDownloadShelfVisible() != visible) {
(...skipping 1467 matching lines...) Expand 10 before | Expand all | Expand 10 after
2603 2603
2604 Browser* modal_browser = 2604 Browser* modal_browser =
2605 chrome::FindBrowserWithWebContents(active_dialog->web_contents()); 2605 chrome::FindBrowserWithWebContents(active_dialog->web_contents());
2606 if (modal_browser && (browser_ != modal_browser)) { 2606 if (modal_browser && (browser_ != modal_browser)) {
2607 modal_browser->window()->FlashFrame(true); 2607 modal_browser->window()->FlashFrame(true);
2608 modal_browser->window()->Activate(); 2608 modal_browser->window()->Activate();
2609 } 2609 }
2610 2610
2611 AppModalDialogQueue::GetInstance()->ActivateModalDialog(); 2611 AppModalDialogQueue::GetInstance()->ActivateModalDialog();
2612 } 2612 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698