Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 11896021: Change the one-click sign in confirmation bubble into a modal dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/frame/browser_view.h" 5 #include "chrome/browser/ui/views/frame/browser_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/auto_reset.h" 9 #include "base/auto_reset.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 1111 matching lines...) Expand 10 before | Expand all | Expand 10 after
1122 void BrowserView::ShowBookmarkPrompt() { 1122 void BrowserView::ShowBookmarkPrompt() {
1123 GetLocationBarView()->ShowBookmarkPrompt(); 1123 GetLocationBarView()->ShowBookmarkPrompt();
1124 } 1124 }
1125 1125
1126 void BrowserView::ShowChromeToMobileBubble() { 1126 void BrowserView::ShowChromeToMobileBubble() {
1127 GetLocationBarView()->ShowChromeToMobileBubble(); 1127 GetLocationBarView()->ShowChromeToMobileBubble();
1128 } 1128 }
1129 1129
1130 #if defined(ENABLE_ONE_CLICK_SIGNIN) 1130 #if defined(ENABLE_ONE_CLICK_SIGNIN)
1131 void BrowserView::ShowOneClickSigninBubble( 1131 void BrowserView::ShowOneClickSigninBubble(
1132 OneClickSigninBubbleType type,
1132 const StartSyncCallback& start_sync_callback) { 1133 const StartSyncCallback& start_sync_callback) {
1133 OneClickSigninBubbleView::ShowBubble(toolbar_->app_menu(), 1134 OneClickSigninBubbleView::ShowBubble(type, toolbar_, start_sync_callback);
1134 start_sync_callback);
1135 } 1135 }
1136 #endif 1136 #endif
1137 1137
1138 void BrowserView::SetDownloadShelfVisible(bool visible) { 1138 void BrowserView::SetDownloadShelfVisible(bool visible) {
1139 // This can be called from the superclass destructor, when it destroys our 1139 // This can be called from the superclass destructor, when it destroys our
1140 // child views. At that point, browser_ is already gone. 1140 // child views. At that point, browser_ is already gone.
1141 if (browser_ == NULL) 1141 if (browser_ == NULL)
1142 return; 1142 return;
1143 1143
1144 if (visible && IsDownloadShelfVisible() != visible) { 1144 if (visible && IsDownloadShelfVisible() != visible) {
(...skipping 1466 matching lines...) Expand 10 before | Expand all | Expand 10 after
2611 2611
2612 Browser* modal_browser = 2612 Browser* modal_browser =
2613 chrome::FindBrowserWithWebContents(active_dialog->web_contents()); 2613 chrome::FindBrowserWithWebContents(active_dialog->web_contents());
2614 if (modal_browser && (browser_ != modal_browser)) { 2614 if (modal_browser && (browser_ != modal_browser)) {
2615 modal_browser->window()->FlashFrame(true); 2615 modal_browser->window()->FlashFrame(true);
2616 modal_browser->window()->Activate(); 2616 modal_browser->window()->Activate();
2617 } 2617 }
2618 2618
2619 AppModalDialogQueue::GetInstance()->ActivateModalDialog(); 2619 AppModalDialogQueue::GetInstance()->ActivateModalDialog();
2620 } 2620 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698