Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Side by Side Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 11896021: Change the one-click sign in confirmation bubble into a modal dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/frame/browser_view.h" 5 #include "chrome/browser/ui/views/frame/browser_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/auto_reset.h" 9 #include "base/auto_reset.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 1107 matching lines...) Expand 10 before | Expand all | Expand 10 after
1118 void BrowserView::ShowBookmarkPrompt() { 1118 void BrowserView::ShowBookmarkPrompt() {
1119 GetLocationBarView()->ShowBookmarkPrompt(); 1119 GetLocationBarView()->ShowBookmarkPrompt();
1120 } 1120 }
1121 1121
1122 void BrowserView::ShowChromeToMobileBubble() { 1122 void BrowserView::ShowChromeToMobileBubble() {
1123 GetLocationBarView()->ShowChromeToMobileBubble(); 1123 GetLocationBarView()->ShowChromeToMobileBubble();
1124 } 1124 }
1125 1125
1126 #if defined(ENABLE_ONE_CLICK_SIGNIN) 1126 #if defined(ENABLE_ONE_CLICK_SIGNIN)
1127 void BrowserView::ShowOneClickSigninBubble( 1127 void BrowserView::ShowOneClickSigninBubble(
1128 OneClickSigninBubbleType type,
1128 const StartSyncCallback& start_sync_callback) { 1129 const StartSyncCallback& start_sync_callback) {
1129 OneClickSigninBubbleView::ShowBubble(toolbar_->app_menu(), 1130 OneClickSigninBubbleView::ShowBubble(type, toolbar_, start_sync_callback);
1130 start_sync_callback);
1131 } 1131 }
1132 #endif 1132 #endif
1133 1133
1134 void BrowserView::SetDownloadShelfVisible(bool visible) { 1134 void BrowserView::SetDownloadShelfVisible(bool visible) {
1135 // This can be called from the superclass destructor, when it destroys our 1135 // This can be called from the superclass destructor, when it destroys our
1136 // child views. At that point, browser_ is already gone. 1136 // child views. At that point, browser_ is already gone.
1137 if (browser_ == NULL) 1137 if (browser_ == NULL)
1138 return; 1138 return;
1139 1139
1140 if (visible && IsDownloadShelfVisible() != visible) { 1140 if (visible && IsDownloadShelfVisible() != visible) {
(...skipping 1459 matching lines...) Expand 10 before | Expand all | Expand 10 after
2600 2600
2601 Browser* modal_browser = 2601 Browser* modal_browser =
2602 chrome::FindBrowserWithWebContents(active_dialog->web_contents()); 2602 chrome::FindBrowserWithWebContents(active_dialog->web_contents());
2603 if (modal_browser && (browser_ != modal_browser)) { 2603 if (modal_browser && (browser_ != modal_browser)) {
2604 modal_browser->window()->FlashFrame(true); 2604 modal_browser->window()->FlashFrame(true);
2605 modal_browser->window()->Activate(); 2605 modal_browser->window()->Activate();
2606 } 2606 }
2607 2607
2608 AppModalDialogQueue::GetInstance()->ActivateModalDialog(); 2608 AppModalDialogQueue::GetInstance()->ActivateModalDialog();
2609 } 2609 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.h ('k') | chrome/browser/ui/views/sync/one_click_signin_bubble_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698