Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: chrome/browser/ui/browser_window.h

Issue 11896021: Change the one-click sign in confirmation bubble into a modal dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/app/google_chrome_strings.grd ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
7 7
8 #include "base/callback_forward.h" 8 #include "base/callback_forward.h"
9 #include "chrome/browser/lifetime/application_lifetime.h" 9 #include "chrome/browser/lifetime/application_lifetime.h"
10 #include "chrome/browser/ui/base_window.h" 10 #include "chrome/browser/ui/base_window.h"
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 virtual void ShowBookmarkBubble(const GURL& url, bool already_bookmarked) = 0; 211 virtual void ShowBookmarkBubble(const GURL& url, bool already_bookmarked) = 0;
212 212
213 // Shows the bookmark prompt. 213 // Shows the bookmark prompt.
214 // TODO(yosin): Make ShowBookmarkPrompt pure virtual. 214 // TODO(yosin): Make ShowBookmarkPrompt pure virtual.
215 virtual void ShowBookmarkPrompt() {} 215 virtual void ShowBookmarkPrompt() {}
216 216
217 // Shows the Chrome To Mobile bubble. 217 // Shows the Chrome To Mobile bubble.
218 virtual void ShowChromeToMobileBubble() = 0; 218 virtual void ShowChromeToMobileBubble() = 0;
219 219
220 #if defined(ENABLE_ONE_CLICK_SIGNIN) 220 #if defined(ENABLE_ONE_CLICK_SIGNIN)
221 enum OneClickSigninBubbleType {
222 ONE_CLICK_SIGNIN_BUBBLE_TYPE_BUBBLE,
223 ONE_CLICK_SIGNIN_BUBBLE_TYPE_MODAL_DIALOG
224 };
225
221 // Callback type used with the ShowOneClickSigninBubble() method. If the 226 // Callback type used with the ShowOneClickSigninBubble() method. If the
222 // user chooses to accept the sign in, the callback is called to start the 227 // user chooses to accept the sign in, the callback is called to start the
223 // sync process. 228 // sync process.
224 typedef base::Callback<void(OneClickSigninSyncStarter::StartSyncMode)> 229 typedef base::Callback<void(OneClickSigninSyncStarter::StartSyncMode)>
225 StartSyncCallback; 230 StartSyncCallback;
226 231
227 // Shows the one-click sign in bubble. 232 // Shows the one-click sign in bubble.
228 virtual void ShowOneClickSigninBubble( 233 virtual void ShowOneClickSigninBubble(
234 OneClickSigninBubbleType type,
229 const StartSyncCallback& start_sync_callback) = 0; 235 const StartSyncCallback& start_sync_callback) = 0;
230 #endif 236 #endif
231 237
232 // Whether or not the shelf view is visible. 238 // Whether or not the shelf view is visible.
233 virtual bool IsDownloadShelfVisible() const = 0; 239 virtual bool IsDownloadShelfVisible() const = 0;
234 240
235 // Returns the DownloadShelf. 241 // Returns the DownloadShelf.
236 virtual DownloadShelf* GetDownloadShelf() = 0; 242 virtual DownloadShelf* GetDownloadShelf() = 0;
237 243
238 // Shows the confirmation dialog box warning that the browser is closing with 244 // Shows the confirmation dialog box warning that the browser is closing with
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 391
386 // Returns the ToolbarView. 392 // Returns the ToolbarView.
387 virtual ToolbarView* GetToolbarView() const = 0; 393 virtual ToolbarView* GetToolbarView() const = 0;
388 #endif 394 #endif
389 395
390 protected: 396 protected:
391 virtual ~BrowserWindowTesting() {} 397 virtual ~BrowserWindowTesting() {}
392 }; 398 };
393 399
394 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 400 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_
OLDNEW
« no previous file with comments | « chrome/app/google_chrome_strings.grd ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698