Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 11896016: Omnibox: Trim Leading Spaces After Initial Forced-Query '?' (Closed)

Created:
7 years, 11 months ago by Mark P
Modified:
7 years, 11 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Visibility:
Public.

Description

Omnibox: Trim Leading Spaces After Initial Forced-Query '?' BUG=170727 TEST=doesn't crash Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177957

Patch Set 1 #

Total comments: 2

Patch Set 2 : added tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/autocomplete/autocomplete_input.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_input_unittest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mark P
7 years, 11 months ago (2013-01-21 15:37:44 UTC) #1
Peter Kasting
Make sure the following still works correctly: * Search for "foo bar" * Double-check that ...
7 years, 11 months ago (2013-01-21 18:53:15 UTC) #2
Peter Kasting
LGTM
7 years, 11 months ago (2013-01-21 18:53:21 UTC) #3
Peter Kasting
Sigh, three messages... forgot to ask if this could get a test too
7 years, 11 months ago (2013-01-21 18:53:40 UTC) #4
Mark P
Added unit tests. Also did the manual test you requested. Works fine. Submitting. --mark https://codereview.chromium.org/11896016/diff/1/chrome/browser/autocomplete/autocomplete_input.cc ...
7 years, 11 months ago (2013-01-21 20:50:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/11896016/5001
7 years, 11 months ago (2013-01-21 20:51:58 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-21 23:23:28 UTC) #7
Message was sent while issue was closed.
Change committed as 177957

Powered by Google App Engine
This is Rietveld 408576698