Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: tests/corelib/list_iterators_test.dart

Issue 11896013: Add List.reversed to give a reverse fixed-length view of a list. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments, cleanup. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/corelib/list_iterators_test.dart
diff --git a/tests/corelib/list_iterators_test.dart b/tests/corelib/list_iterators_test.dart
index 0be3cf8e061c3b38a1164ea6dff244aa252a86f2..c20e5ebe7d885be5cde542590f835a5b9e1c4959 100644
--- a/tests/corelib/list_iterators_test.dart
+++ b/tests/corelib/list_iterators_test.dart
@@ -5,6 +5,7 @@
class ListIteratorsTest {
static void checkListIterator(List a) {
Iterator it = a.iterator;
+ Expect.isNull(it.current);
for (int i = 0; i < a.length; i++) {
Expect.isTrue(it.moveNext());
var elem = it.current;
@@ -27,27 +28,18 @@ class ListIteratorsTest {
// This is mostly undefined behavior.
Iterator it = g.iterator;
Expect.isTrue(it.moveNext());
- g.removeLast();
Expect.equals(1, it.current);
Expect.isTrue(it.moveNext());
g[1] = 49;
// The iterator keeps the last value.
Expect.equals(2, it.current);
+ Expect.isTrue(it.moveNext());
g.removeLast();
// The iterator keeps the last value.
- Expect.equals(2, it.current);
- Expect.isFalse(it.moveNext());
- Expect.isNull(it.current);
-
- g.clear();
- g.addAll([10, 20]);
- int sum = 0;
- for (var elem in g) {
- sum += elem;
- // Iterator must realize that g has no more elements.
- g.removeLast();
- }
- Expect.equals(10, sum);
+ Expect.equals(3, it.current);
+ Expect.throws(it.moveNext, (e) => e is ConcurrentModificationError);
+ // No progress when throwing.
+ Expect.equals(3, it.current);
}
}

Powered by Google App Engine
This is Rietveld 408576698