https://codereview.chromium.org/11896013/diff/1/sdk/lib/core/list.dart File sdk/lib/core/list.dart (right): https://codereview.chromium.org/11896013/diff/1/sdk/lib/core/list.dart#newcode574 sdk/lib/core/list.dart:574: * list changes its length below the slice used ...
5 years, 2 months ago
(2013-01-21 14:43:40 UTC)
#3
On 2013/01/21 14:43:40, Lasse Reichstein Nielsen wrote: > https://codereview.chromium.org/11896013/diff/1/sdk/lib/core/list.dart > File sdk/lib/core/list.dart (right): > > ...
5 years, 2 months ago
(2013-01-21 15:05:55 UTC)
#4
On 2013/01/21 14:43:40, Lasse Reichstein Nielsen wrote:
> https://codereview.chromium.org/11896013/diff/1/sdk/lib/core/list.dart
> File sdk/lib/core/list.dart (right):
>
>
https://codereview.chromium.org/11896013/diff/1/sdk/lib/core/list.dart#newcod...
> sdk/lib/core/list.dart:574: * list changes its length below the slice used by
> this reversed list.
> On 2013/01/21 14:38:06, floitsch wrote:
> > That's now how iterables work. And ReversedList (like MappedList) shouldn't
> > behave this way either.
> > The Iterator, on the other hand, should catch length changes.
>
>
> So what should it do?
As discussed offline:
The implementation of reversed on list should have the same semantics as if
'reversed' came from Iterable. Example:
var list = [1, 2, 3];
var toto = list.take(5).skip(2).reversed;
list.addAll([4, 5, 6]);
print(toto); // => [5, 4, 3]
Lasse Reichstein Nielsen
https://codereview.chromium.org/11896013/diff/1/sdk/lib/core/list.dart File sdk/lib/core/list.dart (right): https://codereview.chromium.org/11896013/diff/1/sdk/lib/core/list.dart#newcode209 sdk/lib/core/list.dart:209: abstract class BaseListMixin<E> extends Iterable<E> implements List<E> { Moved ...
5 years, 2 months ago
(2013-01-22 10:18:52 UTC)
#5
LGTM. make sure you don't break co19 tests that rely on concurrent modifications. https://codereview.chromium.org/11896013/diff/7001/sdk/lib/collection_dev/list.dart File ...
5 years, 2 months ago
(2013-01-22 14:24:57 UTC)
#6
co19 didn't need changes at all. It's unspecified behavior in any case. https://codereview.chromium.org/11896013/diff/7001/sdk/lib/collection_dev/list.dart File sdk/lib/collection_dev/list.dart ...
5 years, 2 months ago
(2013-01-22 14:55:12 UTC)
#7
Issue 11896013: Add List.reversed to give a reverse fixed-length view of a list.
(Closed)
Created 5 years, 2 months ago by Lasse Reichstein Nielsen
Modified 5 years, 2 months ago
Reviewers: floitsch
Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Comments: 24