Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(111)

Issue 1189593003: Rename Partitions::getRenderingPartition() -> getLayoutPartition() (Closed)

Created:
4 years, 10 months ago by bashi
Modified:
4 years, 10 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, oilpan-reviews, Mads Ager (chromium), zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, slimming-paint-reviews_chromium.org, leviw+bidiwatch_chromium.org, blink-reviews-rendering, jchaffraix+rendering, blink-reviews-paint_chromium.org, dshwang, blink-reviews-wtf_chromium.org, kouhei+heap_chromium.org, Mikhail
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename Partitions::getRenderingPartition() -> layoutPartition() Because it a partition for layout/. Also drop get prefix from following methods. - getBufferPartition() - getFastMallocPartition() - getObjectModelPartition() Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197165

Patch Set 1 #

Total comments: 2

Patch Set 2 : Drop get #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -42 lines) Patch
M Source/core/dom/Node.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/line/InlineBox.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/text/BidiCharacterRun.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/ArrayBufferContents.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/wtf/BitVector.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/wtf/DefaultAllocator.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/DefaultAllocator.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/wtf/FastMalloc.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/wtf/Partitions.h View 1 5 chunks +7 lines, -7 lines 0 comments Download
M Source/wtf/Partitions.cpp View 1 5 chunks +11 lines, -11 lines 0 comments Download
M Source/wtf/text/CString.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/wtf/text/StringImpl.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
bashi
PTAL? Trivial rename.
4 years, 10 months ago (2015-06-16 05:16:23 UTC) #2
haraken
LGTM
4 years, 10 months ago (2015-06-16 05:19:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189593003/1
4 years, 10 months ago (2015-06-16 05:19:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/35435)
4 years, 10 months ago (2015-06-16 05:25:30 UTC) #7
haraken
+tkent-san for wtf/.
4 years, 10 months ago (2015-06-16 05:26:11 UTC) #9
tkent
https://codereview.chromium.org/1189593003/diff/1/Source/wtf/Partitions.h File Source/wtf/Partitions.h (right): https://codereview.chromium.org/1189593003/diff/1/Source/wtf/Partitions.h#newcode69 Source/wtf/Partitions.h:69: ALWAYS_INLINE static PartitionRoot* getLayoutPartition() We don't prepend 'get' to ...
4 years, 10 months ago (2015-06-16 05:28:43 UTC) #10
bashi
https://codereview.chromium.org/1189593003/diff/1/Source/wtf/Partitions.h File Source/wtf/Partitions.h (right): https://codereview.chromium.org/1189593003/diff/1/Source/wtf/Partitions.h#newcode69 Source/wtf/Partitions.h:69: ALWAYS_INLINE static PartitionRoot* getLayoutPartition() On 2015/06/16 05:28:43, tkent wrote: ...
4 years, 10 months ago (2015-06-16 05:38:32 UTC) #11
tkent
lgtm. Please mention all of renamed functions in the CL description.
4 years, 10 months ago (2015-06-16 05:46:50 UTC) #12
bashi
On 2015/06/16 05:46:50, tkent wrote: > lgtm. > > Please mention all of renamed functions ...
4 years, 10 months ago (2015-06-16 06:20:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189593003/20001
4 years, 10 months ago (2015-06-16 06:21:03 UTC) #16
commit-bot: I haz the power
Failed to apply patch for Source/wtf/ArrayBufferContents.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
4 years, 10 months ago (2015-06-16 08:15:10 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189593003/40001
4 years, 10 months ago (2015-06-16 08:26:15 UTC) #22
commit-bot: I haz the power
4 years, 10 months ago (2015-06-16 09:56:05 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197165

Powered by Google App Engine
This is Rietveld 408576698