Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: runtime/vm/runtime_entry_arm64.cc

Issue 1189573004: Use object pool for runtime calls. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/runtime_entry_arm.cc ('k') | runtime/vm/runtime_entry_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/runtime_entry_arm64.cc
diff --git a/runtime/vm/runtime_entry_arm64.cc b/runtime/vm/runtime_entry_arm64.cc
index 553f64c6b4d62809fe8057d595a12502e322df20..a2edb95f28ede8938044ffe57ecbac57f882b3a6 100644
--- a/runtime/vm/runtime_entry_arm64.cc
+++ b/runtime/vm/runtime_entry_arm64.cc
@@ -37,9 +37,9 @@ void RuntimeEntry::Call(Assembler* assembler, intptr_t argument_count) const {
entry =
Simulator::RedirectExternalReference(entry, call_kind, argument_count);
#endif
+ ExternalLabel label(entry);
if (is_leaf()) {
ASSERT(argument_count == this->argument_count());
- ExternalLabel label(entry);
// Since we are entering C++ code, we must restore the C stack pointer from
// the stack limit to an aligned value nearer to the top of the stack.
// We cache the Dart stack pointer and the stack limit in callee-saved
@@ -55,7 +55,7 @@ void RuntimeEntry::Call(Assembler* assembler, intptr_t argument_count) const {
} else {
// Argument count is not checked here, but in the runtime entry for a more
// informative error message.
- __ LoadImmediate(R5, entry, kNoPP);
+ __ LoadExternalLabel(R5, &label, kNotPatchable, PP);
__ LoadImmediate(R4, argument_count, kNoPP);
__ BranchLink(&Isolate::Current()->stub_code()->CallToRuntimeLabel(), PP);
}
« no previous file with comments | « runtime/vm/runtime_entry_arm.cc ('k') | runtime/vm/runtime_entry_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698