Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1189563004: Re-Re-land: Enable external startup by default on Linux. (Closed)

Created:
5 years, 6 months ago by vogelheim
Modified:
5 years, 6 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Re-Re-land: Enable external startup by default on Linux. crrev.com/1177163002 should have fixed the issues that broke this last time. Notes: - The current functionality is meant to stay. If you prefer the old way, just set v8_use_external_startup_data=0. - You might notice this if you call d8 via PATH. Either explicitly tell d8 where your external snapshot/built-ins are, or change the build options as above. - This follows Chromium practice, that mostly uses this feature these days. - Other platforms to follow later. BUG= Committed: https://crrev.com/17c1cf28657cbb6163cdf488eabeec1e620ceff7 Cr-Commit-Position: refs/heads/master@{#29050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build/standalone.gypi View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vogelheim
Let's try this again. The fix for the make generator is in (https://codereview.chromium.org/1187073008). Last time, ...
5 years, 6 months ago (2015-06-16 07:41:44 UTC) #2
Michael Achenbach
lgtm - just land at any time - maybe you can make a test CL ...
5 years, 6 months ago (2015-06-16 11:14:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189563004/1
5 years, 6 months ago (2015-06-16 11:25:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-16 11:26:59 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 11:27:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17c1cf28657cbb6163cdf488eabeec1e620ceff7
Cr-Commit-Position: refs/heads/master@{#29050}

Powered by Google App Engine
This is Rietveld 408576698