Issue 1189533002: Revert of Click event should be fired before change events for checkbox and radio button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1189533002: Revert of Click event should be fired before change events for checkbox and radio button. (Closed)

Created:
5 years, 6 months ago by tkent

Modified:
5 years, 6 months ago

Reviewers:
keishi, Paritosh Kumar, philipj_slow

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, Savago

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of Click event should be fired before change events for checkbox and radio button. (patchset #4 id:60001 of https://codereview.chromium.org/842153002/) Reason for revert: Caused a regression, crbug.com/500084. Original issue's description: > Click event should be fired before change events for checkbox and radio button. > > This cl fixes this issue. > > Bug=178505 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193320 TBR=keishi@chromium.org,philipj@opera.com,paritosh.in@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug=178505, 500084 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197097

Created: 5 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -129 lines)			Patch
D	LayoutTests/fast/forms/radio-checkbox-events-order.html	View	1 chunk	+0 lines, -80 lines	0 comments	Download
D	LayoutTests/fast/forms/radio-checkbox-events-order-expected.txt	View	1 chunk	+0 lines, -37 lines	0 comments	Download
M	LayoutTests/fast/forms/radio/radio-group-keyboard-change-event-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLInputElement.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLInputElement.cpp	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	Source/core/html/forms/CheckboxInputType.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/html/forms/RadioInputType.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

tkent

Created Revert of Click event should be fired before change events for checkbox and radio ...

5 years, 6 months ago (2015-06-15 01:54:59 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189533002/1

5 years, 6 months ago (2015-06-15 01:55:01 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-06-15 01:55:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197097