Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 118953003: drive: Stop setting dummy resource ID for "drive" and "other" (Closed)

Created:
7 years ago by hashimoto
Modified:
6 years, 11 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tim+watch_chromium.org, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, tfarina, haitaol+watch_chromium.org, oshima+watch_chromium.org, rsimha+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

drive: Stop setting dummy resource ID for "drive" and "other" Keep resource ID of these entries empty. Remove IsSpecialResourceID(). BUG=324717 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243539

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -36 lines) Patch
M chrome/browser/chromeos/drive/change_list_processor_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_util.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_util.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_util_unittest.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hashimoto
6 years, 11 months ago (2014-01-08 08:13:09 UTC) #1
kinaba
lgtm great!
6 years, 11 months ago (2014-01-08 09:05:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/118953003/80001
6 years, 11 months ago (2014-01-08 09:27:07 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 12:47:48 UTC) #4
Message was sent while issue was closed.
Change committed as 243539

Powered by Google App Engine
This is Rietveld 408576698