Issue 118953002: Add base:: to string16 in content/.

Issue 118953002: Add base:: to string16 in content/. (Closed)

Created:
7 years ago by Dan Beam

Modified:
7 years ago

Reviewers:
brettw

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, miu+watch_chromium.org, jam, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add base:: to string16 in content/. R=brettw@chromium.org BUG=329295 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242051

Patch Set 3 : indent #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -17 lines)			Patch
M	content/browser/android/date_time_chooser_android.cc	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/browser_plugin/browser_plugin_host_browsertest.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/media/webrtc_internals_message_handler.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/public/browser/web_contents_delegate.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

brettw

LGTM, thanks! https://codereview.chromium.org/118953002/diff/20001/content/browser/android/date_time_chooser_android.cc File content/browser/android/date_time_chooser_android.cc (right): https://codereview.chromium.org/118953002/diff/20001/content/browser/android/date_time_chooser_android.cc#newcode37 content/browser/android/date_time_chooser_android.cc:37: static_cast<size_t>(sanitized.length())); Indenting

7 years ago (2013-12-19 21:08:02 UTC) #2

Dan Beam

https://codereview.chromium.org/118953002/diff/20001/content/browser/android/date_time_chooser_android.cc File content/browser/android/date_time_chooser_android.cc (right): https://codereview.chromium.org/118953002/diff/20001/content/browser/android/date_time_chooser_android.cc#newcode37 content/browser/android/date_time_chooser_android.cc:37: static_cast<size_t>(sanitized.length())); On 2013/12/19 21:08:02, brettw wrote: > Indenting Done.

7 years ago (2013-12-19 21:17:18 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/118953002/40001

7 years ago (2013-12-19 21:21:44 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=108283

7 years ago (2013-12-20 02:43:39 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/118953002/40001

7 years ago (2013-12-20 02:59:00 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r242051 (presubmit successful).

Expand Messages | Collapse Messages