Fix memory leaks caused by PromiseRejectionEvents

Fix memory leaks caused by PromiseRejectionEvents

BUG=501484, 495801
R=yurys@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197363

[yurys, 2015-06-18 13:03:21]

lgtm

https://codereview.chromium.org/1189513004/diff/1/Source/core/events/PromiseR...
File Source/core/events/PromiseRejectionEvent.cpp (right):

https://codereview.chromium.org/1189513004/diff/1/Source/core/events/PromiseR...
Source/core/events/PromiseRejectionEvent.cpp:34: v8::Local<v8::Value> value =
m_promise.newLocal(state->isolate());
Should there be a check that the promise is not passed to a script from a
ScriptState with different origin?

[jochen (gone - plz use gerrit), 2015-06-18 13:25:23]

https://codereview.chromium.org/1189513004/diff/1/Source/core/events/PromiseR...
File Source/core/events/PromiseRejectionEvent.cpp (right):

https://codereview.chromium.org/1189513004/diff/1/Source/core/events/PromiseR...
Source/core/events/PromiseRejectionEvent.cpp:34: v8::Local<v8::Value> value =
m_promise.newLocal(state->isolate());
On 2015/06/18 at 13:03:21, yurys wrote:
> Should there be a check that the promise is not passed to a script from a
ScriptState with different origin?

if you manage to get the event in a different context, you're already busted
(also, the current implementation doesn't check either)

[jochen (gone - plz use gerrit), 2015-06-18 13:25:27]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2015-06-18 13:25:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1189513004/1

[commit-bot: I haz the power, 2015-06-18 15:41:45]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197363

[haraken, 2015-06-18 16:00:46]

LGTM as a short-term fix, but as Jochen filed a bug
(https://code.google.com/p/chromium/issues/detail?id=501866), this is a kind of
fundamental leak we need to find a better solution.