Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Side by Side Diff: pkg/intl/test/find_default_locale_browser_test.dart

Issue 11895005: Fix tests to accept short locale names as long as long ones, properly this time. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix bad syntax in previous fix Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | pkg/intl/test/find_default_locale_standalone_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library find_default_locale_browser_test; 5 library find_default_locale_browser_test;
6 6
7 import 'package:intl/intl.dart'; 7 import 'package:intl/intl.dart';
8 import 'package:intl/intl_browser.dart'; 8 import 'package:intl/intl_browser.dart';
9 import 'package:unittest/unittest.dart'; 9 import 'package:unittest/unittest.dart';
10 10
11 main() { 11 main() {
12 test("Find system locale in browser", () { 12 test("Find system locale in browser", () {
13 // TODO (alanknight): This only verifies that we found some locale. We 13 // TODO (alanknight): This only verifies that we found some locale. We
14 // should find a way to force the system locale before the test is run 14 // should find a way to force the system locale before the test is run
15 // and then verify that it's actually the correct value. 15 // and then verify that it's actually the correct value.
16 Intl.systemLocale = 'xx_YY'; 16 Intl.systemLocale = 'xx_YY';
17 var callback = expectAsync1(verifyLocale); 17 var callback = expectAsync1(verifyLocale);
18 findSystemLocale().then(callback); 18 findSystemLocale().then(callback);
19 }); 19 });
20 } 20 }
21 21
22 verifyLocale(_) { 22 verifyLocale(_) {
23 expect(Intl.systemLocale, isNot(equals("xx_YY"))); 23 expect(Intl.systemLocale, isNot(equals("xx_YY")));
24 // Allow either en_US or just en type locales. Windows in particular may 24 // Allow either en_US or just en type locales. Windows in particular may
25 // give us just ru for ru_RU 25 // give us just ru for ru_RU
26 var pattern = new RegExp(r"\w\w_[A-Z0-9]+"); 26 var pattern = new RegExp(r"\w\w_[A-Z0-9]+");
27 var shortPattern = new RegExp(r"\w\w\"); 27 var shortPattern = new RegExp(r"\w\w");
28 var match = pattern.hasMatch(Intl.systemLocale); 28 var match = pattern.hasMatch(Intl.systemLocale);
29 var shortMatch = shortPattern.hasMatch(Intl.systemLocale); 29 var shortMatch = shortPattern.hasMatch(Intl.systemLocale);
30 expect(match || shortMatch, isTrue); 30 expect(match || shortMatch, isTrue);
31 } 31 }
OLDNEW
« no previous file with comments | « no previous file | pkg/intl/test/find_default_locale_standalone_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698