Issue 1189483007: Pared the FontWeight constants down to normal and bold.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1189483007: Pared the FontWeight constants down to normal and bold.

Created:
5 years, 6 months ago by hansmuller1

Modified:
5 years, 6 months ago

Reviewers:
hansmuller, abarth-chromium, Hixie

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Pared the FontWeight constants down to normal and bold.

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	sky/sdk/lib/painting/text_style.dart	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

Doesn't this break typography.dart in theme2? Material design uses lots of font weights.

5 years, 6 months ago (2015-06-17 22:59:59 UTC) #6

hansmuller

5 years, 6 months ago (2015-06-17 23:07:05 UTC) #7

On 2015/06/17 22:59:59, abarth wrote:
> Doesn't this break typography.dart in theme2?  Material design uses lots of
font
> weights.

The typography class is OK.

The back and forth about these constants names is here:
https://codereview.chromium.org/1173323004/

Perhaps we should leave the names in, if they come up in UX designs like
Material.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages