Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 1189473007: Removing Nullable<unsigned long> for PeriodicSyncRegistration::m_minPeriod (Closed)

Created:
5 years, 6 months ago by Paritosh Kumar
Modified:
5 years, 6 months ago
Reviewers:
jkarlin, philipj_slow
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removing Nullable<unsigned long> for PeriodicSyncRegistration::m_minPeriod As m_minPeriod will get initialized through dictionary member minPeriod it will have default value 0. This cl also removes has*() for minPeriod, networkState, powerState and tag attribute, as all these are dictionary members with default values, has*() will always return true. BUG=497142 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M Source/modules/background_sync/PeriodicSyncRegistration.h View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Paritosh Kumar
Please have a look.
5 years, 6 months ago (2015-06-16 11:41:35 UTC) #2
jkarlin
lgtm but please update the bug number in the description
5 years, 6 months ago (2015-06-16 11:57:56 UTC) #3
Paritosh Kumar
On 2015/06/16 11:57:56, jkarlin wrote: > lgtm but please update the bug number in the ...
5 years, 6 months ago (2015-06-16 11:59:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189473007/1
5 years, 6 months ago (2015-06-16 12:02:07 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 13:24:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197171

Powered by Google App Engine
This is Rietveld 408576698