Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1189423002: Don't roundtrip to JS to update the length. This is 1) faster (although we don't care) and 2) avoid… (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't roundtrip to JS to update the length. This is 1) faster (although we don't care) and 2) avoids stackchecks that otherwise make the .Assert fail on stack overflow. BUG=chromium:502147 LOG=n Committed: https://crrev.com/554bc07d9627161cd9d65fccb9ec76f37eac72bc Cr-Commit-Position: refs/heads/master@{#29142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/objects.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 6 months ago (2015-06-19 09:05:53 UTC) #2
Igor Sheludko
lgtm
5 years, 6 months ago (2015-06-19 09:18:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189423002/1
5 years, 6 months ago (2015-06-19 09:24:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-19 10:41:58 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 10:42:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/554bc07d9627161cd9d65fccb9ec76f37eac72bc
Cr-Commit-Position: refs/heads/master@{#29142}

Powered by Google App Engine
This is Rietveld 408576698