Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Side by Side Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 1189413005: Fix race when reloading original URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixing unittests Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
7 7
8 #include <list> 8 #include <list>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 // the current one if it should be reused). If none is set returns nullptr. 287 // the current one if it should be reused). If none is set returns nullptr.
288 WebUIImpl* speculative_web_ui() const { 288 WebUIImpl* speculative_web_ui() const {
289 return should_reuse_web_ui_ ? web_ui_.get() : speculative_web_ui_.get(); 289 return should_reuse_web_ui_ ? web_ui_.get() : speculative_web_ui_.get();
290 } 290 }
291 291
292 // Called when we want to instruct the renderer to navigate to the given 292 // Called when we want to instruct the renderer to navigate to the given
293 // navigation entry. It may create a new RenderFrameHost or re-use an existing 293 // navigation entry. It may create a new RenderFrameHost or re-use an existing
294 // one. The RenderFrameHost to navigate will be returned. Returns NULL if one 294 // one. The RenderFrameHost to navigate will be returned. Returns NULL if one
295 // could not be created. 295 // could not be created.
296 RenderFrameHostImpl* Navigate(const FrameNavigationEntry& frame_entry, 296 RenderFrameHostImpl* Navigate(const FrameNavigationEntry& frame_entry,
297 const GURL& dest_url,
Charlie Reis 2015/07/14 22:23:10 nit: List this first, and mention in the comment t
lfg 2015/07/14 22:47:28 Done.
297 const NavigationEntryImpl& entry); 298 const NavigationEntryImpl& entry);
298 299
299 // Instructs the various live views to stop. Called when the user directed the 300 // Instructs the various live views to stop. Called when the user directed the
300 // page to stop loading. 301 // page to stop loading.
301 void Stop(); 302 void Stop();
302 303
303 // Notifies the regular and pending RenderViewHosts that a load is or is not 304 // Notifies the regular and pending RenderViewHosts that a load is or is not
304 // happening. Even though the message is only for one of them, we don't know 305 // happening. Even though the message is only for one of them, we don't know
305 // which one so we tell both. 306 // which one so we tell both.
306 void SetIsLoading(bool is_loading); 307 void SetIsLoading(bool is_loading);
(...skipping 492 matching lines...) Expand 10 before | Expand all | Expand 10 after
799 bool should_reuse_web_ui_; 800 bool should_reuse_web_ui_;
800 801
801 base::WeakPtrFactory<RenderFrameHostManager> weak_factory_; 802 base::WeakPtrFactory<RenderFrameHostManager> weak_factory_;
802 803
803 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostManager); 804 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostManager);
804 }; 805 };
805 806
806 } // namespace content 807 } // namespace content
807 808
808 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 809 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698