chrome/browser/ssl/captive_portal_blocking_page.h - Issue 1189413003: Added CaptivePortal Interstitial to chrome://interstitials

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/captive_portal_blocking_page.h

Issue 1189413003: Added CaptivePortal Interstitial to chrome://interstitials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Some style changes Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/security_warnings/interstitial_ui.html ('K') | « chrome/browser/resources/security_warnings/interstitial_ui.html ('k') | chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc » ('j') | chrome/browser/ui/webui/interstitials/interstitial_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/captive_portal_blocking_page.h

diff --git a/chrome/browser/ssl/captive_portal_blocking_page.h b/chrome/browser/ssl/captive_portal_blocking_page.h

index 1fe4bf1c155e22567b5f20f5c8d9e366882877a2..089a9a1b9f7beec93c6d880e4efd23a61126a7a7 100644

--- a/chrome/browser/ssl/captive_portal_blocking_page.h

+++ b/chrome/browser/ssl/captive_portal_blocking_page.h

@@ -57,7 +57,8 @@ class CaptivePortalBlockingPage : public SecurityInterstitialPage {

// SecurityInterstitialPage method:

const void* GetTypeForTesting() const override;

- void SetDelegateForTesting(Delegate* delegate) { delegate_.reset(delegate); }

+ // Should only used for testing and chrome://interstitials page

meacer 2015/06/19 22:50:37 "Should only be used". Add a period at the end of

Bhanu Dev 2015/06/19 23:21:33 Done.

+ void SetDelegate(Delegate* delegate) { delegate_.reset(delegate); }

protected:

// SecurityInterstitialPage methods: