chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc - Issue 1189413003: Added CaptivePortal Interstitial to chrome://interstitials

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc

Issue 1189413003: Added CaptivePortal Interstitial to chrome://interstitials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Accept url params, display different interstitials for wifi and non-wifi networks Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc

diff --git a/chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc b/chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc

index f5379bed748dce09a0dc3ae5b337613cb675536a..8fe88931a3409148b537ab08b57c1edfcb302126 100644

--- a/chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc

+++ b/chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc

@@ -55,4 +55,8 @@ IN_PROC_BROWSER_TEST_F(InterstitialUITest, DISABLED_OpenInterstitial) {

TestInterstitial(

GURL("chrome://interstitials/safebrowsing?type=clientside_phishing"),

"Security error");

+ TestInterstitial(GURL("chrome://interstitials/captiveportal"),

+ "Connect to network");

+ TestInterstitial(GURL("chrome://interstitials/captiveportal?is_wifi=1"),

+ "Connect to Wi-Fi");

}

« chrome/browser/ui/webui/interstitials/interstitial_ui.cc ('K') | « chrome/browser/ui/webui/interstitials/interstitial_ui.cc ('k') | no next file » | no next file with comments »