chrome/browser/resources/security_warnings/interstitial_ui.html - Issue 1189413003: Added CaptivePortal Interstitial to chrome://interstitials

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/security_warnings/interstitial_ui.html

Issue 1189413003: Added CaptivePortal Interstitial to chrome://interstitials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Accept url params, display different interstitials for wifi and non-wifi networks Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/security_warnings/interstitial_ui.html

diff --git a/chrome/browser/resources/security_warnings/interstitial_ui.html b/chrome/browser/resources/security_warnings/interstitial_ui.html

index a2fc0275f41acf515e07ec85d43946e0505b7311..dfe9d6eebbb374b2e88d434935d0ee05379cb6ea 100644

--- a/chrome/browser/resources/security_warnings/interstitial_ui.html

+++ b/chrome/browser/resources/security_warnings/interstitial_ui.html

@@ -17,5 +17,9 @@

<a href='safebrowsing?type=phishing'>Phishing</a><br>

<a href='safebrowsing?type=clientside_malware'>Client Side Malware</a><br>

<a href='safebrowsing?type=clientside_phishing'>Client Side Phishing</a><br>

+ <br><br>

+ <h3>Captive Portal</h3>

+ <a href='captiveportal?url=https://google.com&landing_page=https://captive.portal/login'>google.com</a><br>

+ <a href='captiveportal?url=https://google.com&landing_page=https://captive.portal/login&is_wifi=1&wifi_name=CoffeeShopWifi'>google.com (On Wifi "CoffeeShopWifi")</a><br>

Bhanu Dev 2015/06/19 21:09:03 Are the labels good, or should I change them. Than

meacer 2015/06/19 21:23:18 How about making this a bit fancier? Add a default

Bhanu Dev 2015/06/19 22:35:50 Done.

Bhanu Dev 2015/06/19 22:35:51 Done.

</body>

</html>

« no previous file with comments | « no previous file | chrome/browser/ui/webui/interstitials/interstitial_ui.cc » ('j') | chrome/browser/ui/webui/interstitials/interstitial_ui.cc » ('J')