chrome/browser/resources/security_warnings/interstitial_ui.html - Issue 1189413003: Added CaptivePortal Interstitial to chrome://interstitials

Side by Side Diff: chrome/browser/resources/security_warnings/interstitial_ui.html

Issue 1189413003: Added CaptivePortal Interstitial to chrome://interstitials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes to the chrome://interstitials html page Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <title>Interstitials</title>	3 <title>Interstitials</title>

4 </head>	4 </head>

5 <body>	5 <body>

6 <h2>Choose an interstitial<h2>	6 <h2>Choose an interstitial<h2>

7 <h3>SSL</h3>	7 <h3>SSL</h3>

8 <a href='ssl'>example.com</a><br>	8 <a href='ssl'>example.com</a><br>

9 <a href='ssl?url=https://google.com'>SSL (google.com)</a><br>	9 <a href='ssl?url=https://google.com'>SSL (google.com)</a><br>

10 <a href='ssl?overridable=1&strict_enforcement=0'>example.com (Overridable)</a>	10 <a href='ssl?overridable=1&strict_enforcement=0'>example.com (Overridable)</a>

11 <br>	11 <br>

12 <a href='ssl?clock_manipulation=2'>Clock is ahead</a><br>	12 <a href='ssl?clock_manipulation=2'>Clock is ahead</a><br>

13 <a href='ssl?clock_manipulation=-2'>Clock is behind</a><br>	13 <a href='ssl?clock_manipulation=-2'>Clock is behind</a><br>

14 <br><br>	14 <br><br>

15 <h3>SafeBrowsing</h3>	15 <h3>SafeBrowsing</h3>

16 <a href='safebrowsing?type=malware'>Malware</a><br>	16 <a href='safebrowsing?type=malware'>Malware</a><br>

17 <a href='safebrowsing?type=phishing'>Phishing</a><br>	17 <a href='safebrowsing?type=phishing'>Phishing</a><br>

18 <a href='safebrowsing?type=clientside_malware'>Client Side Malware</a><br>	18 <a href='safebrowsing?type=clientside_malware'>Client Side Malware</a><br>

19 <a href='safebrowsing?type=clientside_phishing'>Client Side Phishing</a><br>	19 <a href='safebrowsing?type=clientside_phishing'>Client Side Phishing</a><br>

	20 <br><br>

	21 <h3>Captive Portal</h3>

	22 <a href='captiveportal'>google.com (Captive Portal, Non-Wifi)</a><br>

	23 <a href='captiveportal?is_wifi=1'>

	24 google.com (Captive Portal, on some Wifi)</a><br>
	Bernhard Bauer 2015/06/23 08:48:47 Indent this line by two spaces, then break before Indent this line by two spaces, then break before the closing </a>, which should be aligned with the opening <a> again. Essentially, you are not breaking a single long line, you're opening and closing a new scope, so everything inside that scope is indented two spaces. FTR, the Chromium style guidelines for Web UI are here: http://dev.chromium.org/developers/web-development-style-guide (and refering to the Google HTML/CSS style guidelines, which are here: http://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml). Bhanu Dev 2015/06/23 18:26:46 Done. Thank you for the details about scope.. Show quoted text On 2015/06/23 08:48:47, Bernhard Bauer wrote: > Indent this line by two spaces, then break before the closing </a>, which should > be aligned with the opening <a> again. Essentially, you are not breaking a > single long line, you're opening and closing a new scope, so everything inside > that scope is indented two spaces. FTR, the Chromium style guidelines for Web UI > are here: http://dev.chromium.org/developers/web-development-style-guide (and > refering to the Google HTML/CSS style guidelines, which are here: > http://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml). Done. Thank you for the details about scope..
	25 <a href='captiveportal?is_wifi=1&wifi_name=CoffeeShopWifi'>

	26 google.com (CaptivePortal, on wifi "CoffeeShopWifi")</a><br>

20 </body>	27 </body>

21 </html>	28 </html>

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/ssl/captive_portal_blocking_page.h » ('j') | no next file with comments »