Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(46)

Issue 1189403002: Fix Preloader Meta Accept-CH bug (Closed)

Created:
4 years, 10 months ago by Yoav Weiss
Modified:
4 years, 10 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix Preloader Meta Accept-CH bug The previous addition of HTMLPreloadScanner support for meta Accept-CH tags [1] was buggy, and the tests were buggy as well and failed to catch that :( This CL fixes that bug, by parsing the actual header value, rather than the header name (doh!). [1] https://codereview.chromium.org/1121263002/ BUG=482840 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197470

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Fix broken tests #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M Source/core/html/parser/HTMLPreloadScanner.cpp View 1 1 chunk +6 lines, -3 lines 1 comment Download
M Source/core/html/parser/HTMLPreloadScannerTest.cpp View 1 2 3 chunks +14 lines, -8 lines 0 comments Download
M Source/core/html/parser/PreloadRequest.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Yoav Weiss
Hey Mike! Can you take a look?
4 years, 10 months ago (2015-06-19 10:58:24 UTC) #2
Mike West
LGTM: Can you add some detail to the CL description explaining the bug that this ...
4 years, 10 months ago (2015-06-19 12:16:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189403002/40001
4 years, 10 months ago (2015-06-19 13:35:24 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 13:38:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197470

Powered by Google App Engine
This is Rietveld 408576698