Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 1189393002: [gcc 4.x] Fix the broken build reported due to uninitialized |status| variable. (Closed)

Created:
5 years, 6 months ago by vivekg_samsung
Modified:
5 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[gcc 4.x] Fix the broken build reported due to uninitialized |status| variable. CL, https://codereview.chromium.org/1180013006, has introduced a loop breaking condition due to which gcc 4.8 toolchain reports the following error: In member function ‘bool blink::JPEGImageReader::decode(const blink::SharedBuffer&, bool)’: Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:554:81: error: ‘status’ may be used uninitialized in this function [-Werror=maybe-uninitialized] if (!m_info.output_scan_number && (scan > 1) && (status != JPEG_REACHED_EOI)) ^ We need to initialize the variable explicitly. Using value 0 is safe. BUG=500567 R=noel@chromium.org, pkasting@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197458

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
vivekg
PTAL, thanks!
5 years, 6 months ago (2015-06-19 08:13:41 UTC) #2
Noel Gordon
LGTM
5 years, 6 months ago (2015-06-19 08:34:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189393002/1
5 years, 6 months ago (2015-06-19 08:35:27 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 09:17:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197458

Powered by Google App Engine
This is Rietveld 408576698