runtime/vm/scopes.cc - Issue 11893002: Improve compilation speed on a pathological case > 2x (7 sec -> 2.7 sec) by improving local lookups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/scopes.cc

Issue 11893002: Improve compilation speed on a pathological case > 2x (7 sec -> 2.7 sec) by improving local lookups. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/scopes.cc

===================================================================

--- runtime/vm/scopes.cc (revision 17040)

+++ runtime/vm/scopes.cc (working copy)

@@ -294,9 +294,11 @@

LocalVariable* LocalScope::LocalLookupVariable(const String& name) const {

+ ASSERT(name.IsSymbol());

for (intptr_t i = 0; i < variables_.length(); i++) {

LocalVariable* var = variables_[i];

- if (var->name().Equals(name) && !var->is_invisible_) {

+ ASSERT(var->name().IsSymbol());

+ if ((var->name().raw() == name.raw()) && !var->is_invisible_) {

return var;

}

« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/scopes_test.cc » ('j') | no next file with comments »