Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: components/password_manager/core/browser/password_manager_unittest.cc

Issue 1189293003: Removing PasswordForm::password_auto_complete_set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/core/common/save_password_progress_logger.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_manager_unittest.cc b/components/password_manager/core/browser/password_manager_unittest.cc
index 1e94e82e548981893842b62bd401039e55ae4957..be3035284f3061c1878c8b33b2ef17494d747f3c 100644
--- a/components/password_manager/core/browser/password_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_manager_unittest.cc
@@ -132,8 +132,6 @@ class PasswordManagerTest : public testing::Test {
form.password_element = ASCIIToUTF16("Passwd");
form.username_value = ASCIIToUTF16("google");
form.password_value = ASCIIToUTF16("password");
- // Default to true so we only need to add tests in autocomplete=off cases.
- form.password_autocomplete_set = true;
form.submit_element = ASCIIToUTF16("signIn");
form.signon_realm = "http://www.google.com";
return form;
@@ -156,7 +154,6 @@ class PasswordManagerTest : public testing::Test {
form.password_element = ASCIIToUTF16("Passwd");
form.username_value = ASCIIToUTF16("twitter");
form.password_value = ASCIIToUTF16("password");
- form.password_autocomplete_set = true;
form.submit_element = ASCIIToUTF16("signIn");
form.signon_realm = "https://twitter.com";
return form;
@@ -171,7 +168,6 @@ class PasswordManagerTest : public testing::Test {
form.password_element = ASCIIToUTF16("PasswdField");
form.username_value = ASCIIToUTF16("twitter");
form.password_value = ASCIIToUTF16("password");
- form.password_autocomplete_set = true;
form.submit_element = ASCIIToUTF16("signIn");
form.signon_realm = "https://twitter.com";
return form;
@@ -202,8 +198,6 @@ class PasswordManagerTest : public testing::Test {
return false;
if (lhs.new_password_value != rhs.new_password_value)
return false;
- if (lhs.password_autocomplete_set != rhs.password_autocomplete_set)
- return false;
if (lhs.submit_element != rhs.submit_element)
return false;
if (lhs.signon_realm != rhs.signon_realm)
@@ -241,7 +235,6 @@ MATCHER_P(FormMatches, form, "") {
form.username_element == arg.username_element &&
form.password_element == arg.password_element &&
form.new_password_element == arg.new_password_element &&
- form.password_autocomplete_set == arg.password_autocomplete_set &&
form.submit_element == arg.submit_element;
}
@@ -601,7 +594,6 @@ TEST_F(PasswordManagerTest, FormSavedWithAutocompleteOff) {
EXPECT_CALL(driver_, FillPasswordForm(_)).Times(Exactly(0));
std::vector<PasswordForm> observed;
PasswordForm form(MakeSimpleForm());
- form.password_autocomplete_set = false;
observed.push_back(form);
manager()->OnPasswordFormsParsed(&driver_, observed); // The initial load.
manager()->OnPasswordFormsRendered(&driver_, observed,
@@ -635,7 +627,6 @@ TEST_F(PasswordManagerTest, GeneratedPasswordFormSavedAutocompleteOff) {
EXPECT_CALL(driver_, FillPasswordForm(_)).Times(Exactly(0));
std::vector<PasswordForm> observed;
PasswordForm form(MakeSimpleForm());
- form.password_autocomplete_set = false;
observed.push_back(form);
manager()->OnPasswordFormsParsed(&driver_, observed); // The initial load.
manager()->OnPasswordFormsRendered(&driver_, observed,
@@ -706,7 +697,6 @@ TEST_F(PasswordManagerTest, SyncCredentialsNotSaved) {
EXPECT_CALL(driver_, FillPasswordForm(_)).Times(Exactly(0));
std::vector<PasswordForm> observed;
PasswordForm form(MakeSimpleForm());
- form.password_autocomplete_set = false;
observed.push_back(form);
manager()->OnPasswordFormsParsed(&driver_, observed); // The initial load.
manager()->OnPasswordFormsRendered(&driver_, observed,
« no previous file with comments | « components/autofill/core/common/save_password_progress_logger.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698