Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Unified Diff: src/snapshot/serialize.cc

Issue 1189183002: Serializer: do not miss outdated contexts if they are serialized deferred. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/test-serialize.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/snapshot/serialize.cc
diff --git a/src/snapshot/serialize.cc b/src/snapshot/serialize.cc
index fe33c3e8b2d71e86aa6322ab5ff69700baa7b298..66c47195ed2779d727da0350ac584b6ab464455a 100644
--- a/src/snapshot/serialize.cc
+++ b/src/snapshot/serialize.cc
@@ -617,8 +617,8 @@ MaybeHandle<Object> Deserializer::DeserializePartial(
Object* root;
Object* outdated_contexts;
VisitPointer(&root);
- VisitPointer(&outdated_contexts);
DeserializeDeferredObjects();
+ VisitPointer(&outdated_contexts);
// There's no code deserialized here. If this assert fires then that's
// changed and logging should be added to notify the profiler et al of the
@@ -1395,8 +1395,8 @@ void PartialSerializer::Serialize(Object** o) {
back_reference_map()->AddGlobalProxy(context->global_proxy());
}
VisitPointer(o);
- SerializeOutdatedContextsAsFixedArray();
SerializeDeferredObjects();
+ SerializeOutdatedContextsAsFixedArray();
Pad();
}
« no previous file with comments | « no previous file | test/cctest/test-serialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698