Adding thread id to PartitionAlloc memory dumps dumps for single process mode and bug fix.

Source/platform/PartitionAllocMemoryDumpProvider.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "Source/platform/PartitionAllocMemoryDumpProvider.h"
 
 #include "public/platform/WebMemoryAllocatorDump.h"
 #include "public/platform/WebProcessMemoryDump.h"
 #include "wtf/Partitions.h"
+#include "wtf/Threading.h"
 
 namespace blink {
 
 namespace {
 
 using namespace WTF;
 
 // This class is used to invert the dependency of PartitionAlloc on the
 // PartitionAllocMemoryDumpProvider. This implements an interface that will
 // be called with memory statistics for each bucket in the allocator.
 class PartitionStatsDumperImpl final : public PartitionStatsDumper {
 public:
     explicit PartitionStatsDumperImpl(WebProcessMemoryDump* memoryDump)
         : m_memoryDump(memoryDump), m_uid(0) { }
 
     // PartitionStatsDumper implementation.
     void partitionsDumpBucketStats(const char* partitionName, const PartitionBucketMemoryStats*) override;
 
 private:
     WebProcessMemoryDump* m_memoryDump;
     size_t m_uid;
 };
 
 void PartitionStatsDumperImpl::partitionsDumpBucketStats(const char* partitionName, const PartitionBucketMemoryStats* memoryStats)
 {
     ASSERT(memoryStats->isValid);
     String dumpName;
     if (memoryStats->isDirectMap)
-        dumpName = String::format("partition_alloc/%s/directMap_%zu", partitionName, ++m_uid);
+        dumpName = String::format("partition_alloc/thread_%lu/%s/directMap_%lu", static_cast<unsigned long>(WTF::currentThread()), partitionName, ++m_uid);

[haraken, 2015/06/18 17:55:30]

Instead of calling WTF::currentThread() here, can we pass in the thread id to
partitionsDumpBucketStats (or include the thread id in partitionName)?

We want to keep PartitionAlloc an isolated library as much as possible (i.e.,
reduce the dependency on other classes). We have a plan to port PartitionAlloc
to Chromium.

[ssid, 2015/06/18 20:55:24]

This module depends on Partitions.h, and Partitions.cpp already works with
threading.
I have added the id as uint64_t since some platforms define ThreadIdentifier as
unsigned long int and that is the biggest type.

Passing around a String means PartitionAlloc should depend on WTF::String now
since it has to use String::format. So I just passed the id and converting it to
string at the provider.

     else
-        dumpName = String::format("partition_alloc/%s/bucket_%zu", partitionName, static_cast<size_t>(memoryStats->bucketSlotSize));
+        dumpName = String::format("partition_alloc/thread_%lu/%s/bucket_%u", static_cast<unsigned long>(WTF::currentThread()), partitionName, static_cast<unsigned>(memoryStats->bucketSlotSize));
 
     WebMemoryAllocatorDump* allocatorDump = m_memoryDump->createMemoryAllocatorDump(dumpName);
     allocatorDump->AddScalar("size", "bytes", memoryStats->residentBytes);
     allocatorDump->AddScalar("slot_size", "bytes", memoryStats->bucketSlotSize);
     allocatorDump->AddScalar("active_size", "bytes", memoryStats->activeBytes);
     allocatorDump->AddScalar("resident_size", "bytes", memoryStats->residentBytes);
     allocatorDump->AddScalar("freeable_size", "bytes", memoryStats->freeableBytes);
     allocatorDump->AddScalar("num_active", "objects", memoryStats->numActivePages);
     allocatorDump->AddScalar("num_full", "objects", memoryStats->numFullPages);
     allocatorDump->AddScalar("num_empty", "objects", memoryStats->numEmptyPages);
@@ skipping 24 matching lines @@
 
 PartitionAllocMemoryDumpProvider::PartitionAllocMemoryDumpProvider()
 {
 }
 
 PartitionAllocMemoryDumpProvider::~PartitionAllocMemoryDumpProvider()
 {
 }
 
 } // namespace blink