Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: src/ic/ic-inl.h

Issue 1189153002: Revert of [strong] Implement strong mode restrictions on property access (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/ic-compiler.cc ('k') | src/ic/ic-state.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_IC_INL_H_ 5 #ifndef V8_IC_INL_H_
6 #define V8_IC_INL_H_ 6 #define V8_IC_INL_H_
7 7
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 9
10 #include "src/compiler.h" 10 #include "src/compiler.h"
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 void IC::set_target(Code* code) { 128 void IC::set_target(Code* code) {
129 SetTargetAtAddress(address(), code, constant_pool()); 129 SetTargetAtAddress(address(), code, constant_pool());
130 target_set_ = true; 130 target_set_ = true;
131 } 131 }
132 132
133 133
134 void LoadIC::set_target(Code* code) { 134 void LoadIC::set_target(Code* code) {
135 // The contextual mode must be preserved across IC patching. 135 // The contextual mode must be preserved across IC patching.
136 DCHECK(LoadICState::GetContextualMode(code->extra_ic_state()) == 136 DCHECK(LoadICState::GetContextualMode(code->extra_ic_state()) ==
137 LoadICState::GetContextualMode(target()->extra_ic_state())); 137 LoadICState::GetContextualMode(target()->extra_ic_state()));
138 // Strongness must be preserved across IC patching.
139 DCHECK(LoadICState::GetLanguageMode(code->extra_ic_state()) ==
140 LoadICState::GetLanguageMode(target()->extra_ic_state()));
141 138
142 IC::set_target(code); 139 IC::set_target(code);
143 } 140 }
144 141
145 142
146 void StoreIC::set_target(Code* code) { 143 void StoreIC::set_target(Code* code) {
147 // Language mode must be preserved across IC patching. 144 // Language mode must be preserved across IC patching.
148 DCHECK(StoreICState::GetLanguageMode(code->extra_ic_state()) == 145 DCHECK(StoreICState::GetLanguageMode(code->extra_ic_state()) ==
149 StoreICState::GetLanguageMode(target()->extra_ic_state())); 146 StoreICState::GetLanguageMode(target()->extra_ic_state()));
150 IC::set_target(code); 147 IC::set_target(code);
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 bool IC::AddressIsDeoptimizedCode(Isolate* isolate, Address address) { 229 bool IC::AddressIsDeoptimizedCode(Isolate* isolate, Address address) {
233 Code* host = 230 Code* host =
234 isolate->inner_pointer_to_code_cache()->GetCacheEntry(address)->code; 231 isolate->inner_pointer_to_code_cache()->GetCacheEntry(address)->code;
235 return (host->kind() == Code::OPTIMIZED_FUNCTION && 232 return (host->kind() == Code::OPTIMIZED_FUNCTION &&
236 host->marked_for_deoptimization()); 233 host->marked_for_deoptimization());
237 } 234 }
238 } 235 }
239 } // namespace v8::internal 236 } // namespace v8::internal
240 237
241 #endif // V8_IC_INL_H_ 238 #endif // V8_IC_INL_H_
OLDNEW
« no previous file with comments | « src/ic/ic-compiler.cc ('k') | src/ic/ic-state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698