Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 1189123003: ARM: make predictable code size scope more precise in DoDeferredInstanceOfKnownGlobal. (Closed)

Created:
5 years, 6 months ago by ulan
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ARM: make predictable code size scope more precise in DoDeferredInstanceOfKnownGlobal. We block constant pool up to the call stub instruction, but the check for code size includes the next instruction after the call instruction. That instruction can emit constant pool. BUG=chromium:500831 LOG=NO TEST=mjsunit/regress/regress-500831 Committed: https://crrev.com/fda60dc2148093909323d85b7be0fa8a05c1ec39 Cr-Commit-Position: refs/heads/master@{#29132}

Patch Set 1 #

Patch Set 2 : Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -28 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +32 lines, -28 lines 0 comments Download
A test/mjsunit/regress/regress-500831.js View 1 chunk +94 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL
5 years, 6 months ago (2015-06-18 14:53:03 UTC) #2
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-19 04:28:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189123003/20001
5 years, 6 months ago (2015-06-19 04:28:53 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-19 04:54:48 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 04:55:03 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fda60dc2148093909323d85b7be0fa8a05c1ec39
Cr-Commit-Position: refs/heads/master@{#29132}

Powered by Google App Engine
This is Rietveld 408576698