Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(27)

Issue 1189053002: Upgrade WebGLImageConversion to ES3: Part I. (Closed)

Created:
4 years, 10 months ago by Zhenyao Mo
Modified:
4 years, 10 months ago
CC:
blink-reviews, krit, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Upgrade WebGLImageConversion to ES3: Part I. In this CL, we haven't added the actual unpack/pack of various new formats, but the general structure of handing them are there. BUG=497352 TEST=webgl conformance tests R=kbr@chromium.org,bajones@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197310

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -15 lines) Patch
M Source/platform/graphics/gpu/WebGLImageConversion.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/gpu/WebGLImageConversion.cpp View 7 chunks +181 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Zhenyao Mo
Please review. I have tested with WebGL conformance 1.0.4 on Linux, no regressions. I can't ...
4 years, 10 months ago (2015-06-17 23:59:22 UTC) #1
Ken Russell (switch to Gerrit)
Super. LGTM as long as it passes the tests.
4 years, 10 months ago (2015-06-18 01:33:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189053002/20001
4 years, 10 months ago (2015-06-18 01:41:42 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 02:55:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197310

Powered by Google App Engine
This is Rietveld 408576698