Issue 1189053002: Upgrade WebGLImageConversion to ES3: Part I.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1189053002: Upgrade WebGLImageConversion to ES3: Part I. (Closed)

Created:
4 years, 10 months ago by Zhenyao Mo

Modified:
4 years, 10 months ago

Reviewers:
Ken Russell (switch to Gerrit), bajones

CC:
blink-reviews, krit, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

Upgrade WebGLImageConversion to ES3: Part I. In this CL, we haven't added the actual unpack/pack of various new formats, but the general structure of handing them are there. BUG=497352 TEST=webgl conformance tests R=kbr@chromium.org,bajones@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197310

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+182 lines, -15 lines)			Patch
	M	Source/platform/graphics/gpu/WebGLImageConversion.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	Source/platform/graphics/gpu/WebGLImageConversion.cpp	View		7 chunks	+181 lines, -15 lines	0 comments	Download

Total messages: 5 (1 generated)

Zhenyao Mo

Please review. I have tested with WebGL conformance 1.0.4 on Linux, no regressions. I can't ...

4 years, 10 months ago (2015-06-17 23:59:22 UTC) #1

Ken Russell (switch to Gerrit)

Super. LGTM as long as it passes the tests.

4 years, 10 months ago (2015-06-18 01:33:11 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189053002/20001

4 years, 10 months ago (2015-06-18 01:41:42 UTC) #4

commit-bot: I haz the power

4 years, 10 months ago (2015-06-18 02:55:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197310