Stub in more IPC attachment brokering functionality.

ipc/mojo/ipc_channel_mojo.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ipc/mojo/ipc_channel_mojo.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/lazy_instance.h"
 #include "base/thread_task_runner_handle.h"
@@ skipping 536 matching lines @@
 #else
           NOTREACHED();
 #endif  //  defined(OS_POSIX) && !defined(OS_NACL)
         break;
         case MessageAttachment::TYPE_MOJO_HANDLE: {
           mojo::ScopedHandle handle =
               static_cast<IPC::internal::MojoHandleAttachment*>(
                   attachment.get())->TakeHandle();
           handles->push_back(handle.release().value());
         } break;
-        case MessageAttachment::TYPE_WIN_HANDLE:
-          NOTREACHED();
+        case MessageAttachment::TYPE_BROKERABLE_ATTACHMENT:
+          // Brokerable attachments are handled by the AttachmentBroker so

[Tom Sepez, 2015/06/19 18:04:11]

Still need a NOTREACHED() here.

[erikchen, 2015/06/23 22:37:00]

Done.

+          // there's no need to do anything here.
           break;
       }
     }
 
     set->CommitAll();
   }
 
   return MOJO_RESULT_OK;
 }
 
 // static
 MojoResult ChannelMojo::WriteToMessageAttachmentSet(
     const std::vector<MojoHandle>& handle_buffer,
     Message* message) {
   for (size_t i = 0; i < handle_buffer.size(); ++i) {
     bool ok = message->attachment_set()->AddAttachment(
         new IPC::internal::MojoHandleAttachment(
             mojo::MakeScopedHandle(mojo::Handle(handle_buffer[i]))));
     DCHECK(ok);
     if (!ok) {
       LOG(ERROR) << "Failed to add new Mojo handle.";
       return MOJO_RESULT_UNKNOWN;
     }
   }
 
   return MOJO_RESULT_OK;
 }
 
 }  // namespace IPC