Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Unified Diff: ui/base/range/range_win.cc

Issue 11889017: some fixes and warning disables in ui/ for building on win x64 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/range/range_win.cc
diff --git a/ui/base/range/range_win.cc b/ui/base/range/range_win.cc
index 0a349580a4263fa0ac121bdcc2acdbfa12a3eacc..29178b347c30e5c24f9fa09a1fb898125fbb54d4 100644
--- a/ui/base/range/range_win.cc
+++ b/ui/base/range/range_win.cc
@@ -35,10 +35,10 @@ CHARRANGE Range::ToCHARRANGE() const {
return r;
const LONG kLONGMax = std::numeric_limits<LONG>::max();
jschuh 2013/01/14 21:31:39 Any reason why we use a LONG here?
scottmg 2013/01/14 21:45:00 cpMin/cpMax are LONG in windows headers.
jschuh 2013/01/14 22:14:35 Sorry I asked.
- DCHECK_LE(static_cast<LONG>(start()), kLONGMax);
- DCHECK_LE(static_cast<LONG>(end()), kLONGMax);
- r.cpMin = start();
- r.cpMax = end();
+ CHECK_LE(static_cast<LONG>(start()), kLONGMax);
+ CHECK_LE(static_cast<LONG>(end()), kLONGMax);
+ r.cpMin = static_cast<LONG>(start());
+ r.cpMax = static_cast<LONG>(end());
return r;
}

Powered by Google App Engine
This is Rietveld 408576698