Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 11889014: Merge 139459 (Closed)

Created:
7 years, 9 months ago by Ken Russell (switch to Gerrit)
Modified:
7 years, 9 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 139459 > [Chromium] WebGL typed array constructor crashes on exception > https://bugs.webkit.org/show_bug.cgi?id=106308 > > Reviewed by Kentaro Hara. > > Source/WebCore: > > Check for empty handles (indicating exception thrown) after calls > into V8 VM. > > Added new case from Khronos typed array conformance tests to > fast/canvas/webgl/array-unit-tests.html. > > * bindings/v8/custom/V8ArrayBufferViewCustom.h: > (WebCore::constructWebGLArray): > Check for empty handles after calls into V8 VM. > > LayoutTests: > > Updated typed array tests to latest version from Khronos repository. > > * fast/canvas/webgl/array-unit-tests-expected.txt: > * fast/canvas/webgl/array-unit-tests.html: > TBR=kbr@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139640

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M LayoutTests/fast/canvas/webgl/array-unit-tests.html View 2 chunks +11 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt View 9 chunks +9 lines, -0 lines 0 comments Download
M Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h View 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ken Russell (switch to Gerrit)
7 years, 9 months ago (2013-01-14 20:20:47 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698