Fixing ESC in instant-extended.

chrome/renderer/searchbox/searchbox.cc

Index: chrome/renderer/searchbox/searchbox.cc
diff --git a/chrome/renderer/searchbox/searchbox.cc b/chrome/renderer/searchbox/searchbox.cc
index 223c320df5a7b08552eb2b2c6ca7a22ba55eb3cb..80ca2f5d5fe0c7e0ff5203dda403b06d32c07914 100644
--- a/chrome/renderer/searchbox/searchbox.cc
+++ b/chrome/renderer/searchbox/searchbox.cc
@@ -122,6 +122,8 @@ bool SearchBox::OnMessageReceived(const IPC::Message& message) {
                         OnAutocompleteResults)
     IPC_MESSAGE_HANDLER(ChromeViewMsg_SearchBoxUpOrDownKeyPressed,
                         OnUpOrDownKeyPressed)
+    IPC_MESSAGE_HANDLER(ChromeViewMsg_SearchBoxCancelSelection,
+                        OnCancelSelection)
     IPC_MESSAGE_HANDLER(ChromeViewMsg_SearchBoxModeChanged,
                         OnModeChanged)
     IPC_MESSAGE_HANDLER(ChromeViewMsg_SearchBoxSetDisplayInstantResults,
@@ -229,6 +231,18 @@ void SearchBox::OnUpOrDownKeyPressed(int count) {
   }
 }
 
+void SearchBox::OnCancelSelection(const string16& query) {
+  // TODO(sreeram): The state reset below are somewhat wrong. Fix them.

[palmer, 2013/02/13 21:27:54]

I believe it is better to cite a bug # in TODOs.

[beaudoin, 2013/02/13 21:32:38]

Done.

[Peter Kasting, 2013/02/14 21:17:50]

Actually, I ask all my reviewees to not cite bug numbers in comments.  The
comment should give the complete context for the issue on its own.  Linking to
bugs is hazardous, in particular when the bug metastasizes and someone trying to
read it isn't sure what the relevant portion is for the source code in question
any more, and even when that doesn't happen, it's inconvenient to have to go
find and read another bug rather than having all the data there (or to read the
other bug only to find it adds nothing to the comment).

+  query_ = query;
+  verbatim_ = true;
+  selection_start_ = selection_end_ = query_.size();
+  if (render_view()->GetWebView() && render_view()->GetWebView()->mainFrame()) {
+    DVLOG(1) << render_view() << " OnKeyPress ESC";
+    extensions_v8::SearchBoxExtension::DispatchEscKeyPress(
+        render_view()->GetWebView()->mainFrame());
+  }
+}
+
 void SearchBox::OnKeyCaptureChange(bool is_key_capture_enabled) {
   if (is_key_capture_enabled != is_key_capture_enabled_ &&
       render_view()->GetWebView() && render_view()->GetWebView()->mainFrame()) {