Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1797)

Unified Diff: chrome/test/data/instant_extended.html

Issue 11889003: Fixing ESC in instant-extended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Answered Sreeram's comment, fixed Jeremy's problem and updated tests. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/instant_extended.html
diff --git a/chrome/test/data/instant_extended.html b/chrome/test/data/instant_extended.html
index 96c2541b5528f4e9a0c5587c3428c669a2e5cdb9..00aa92d221dd3b606cc024a6a8868f033078b9cf 100644
--- a/chrome/test/data/instant_extended.html
+++ b/chrome/test/data/instant_extended.html
@@ -50,6 +50,7 @@ function previousSuggestion() {
suggestionIndex--;
if (suggestionIndex == -1) {
apiHandle.setValue(savedUserText);
+ suggestionIndex = -1;
sreeram 2013/02/12 20:52:59 Huh? It's already -1, isn't it?
beaudoin 2013/02/12 21:34:41 Done.
} else {
apiHandle.setValue(suggestions[suggestionIndex]);
}
@@ -59,11 +60,15 @@ function previousSuggestion() {
function handleKeyPress(event) {
var VKEY_UP = 0x26;
var VKEY_DOWN = 0x28;
+ var VKEY_ESCAPE = 0x1B;
if (event.keyCode == VKEY_DOWN) {
nextSuggestion();
} else if (event.keyCode == VKEY_UP) {
previousSuggestion();
+ } else if (event.keyCode == VKEY_ESCAPE) {
+ suggestionIndex = -1;
+ apiHandle.setAutocompleteText("helloab", 2)
sreeram 2013/02/12 20:52:59 ???
beaudoin 2013/02/12 21:34:41 Debugging leftovers. :( Done.
}
}

Powered by Google App Engine
This is Rietveld 408576698