chrome/test/data/instant_extended.html - Issue 11889003: Fixing ESC in instant-extended.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/instant_extended.html

Issue 11889003: Fixing ESC in instant-extended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reverted back to asvitkine's fix. REALLY answered PK's comments. :) Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/data/instant_extended.html

diff --git a/chrome/test/data/instant_extended.html b/chrome/test/data/instant_extended.html

index 96c2541b5528f4e9a0c5587c3428c669a2e5cdb9..0f534ff02c935903a1413e2b8633a366bdad2dc2 100644

--- a/chrome/test/data/instant_extended.html

+++ b/chrome/test/data/instant_extended.html

@@ -50,6 +50,7 @@ function previousSuggestion() {

suggestionIndex--;

if (suggestionIndex == -1) {

apiHandle.setValue(savedUserText);

+ suggestionIndex = -1;

} else {

apiHandle.setValue(suggestions[suggestionIndex]);

}

@@ -59,11 +60,14 @@ function previousSuggestion() {

function handleKeyPress(event) {

var VKEY_UP = 0x26;

var VKEY_DOWN = 0x28;

+ var VKEY_ESCAPE = 0x1B;

if (event.keyCode == VKEY_DOWN) {

nextSuggestion();

} else if (event.keyCode == VKEY_UP) {

previousSuggestion();

+ } else if (event.keyCode == VKEY_ESCAPE) {

+ suggestionIndex = -1;

}