Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1188823008: Resurrect painting.sky example as painting.dart. (Closed)

Created:
5 years, 6 months ago by Matt Perry
Modified:
5 years, 6 months ago
Reviewers:
iansf, Hixie
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Resurrect painting.sky example as painting.dart. I use it a lot to test and demo the painting API. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/85a6d0ebf169214bb20b8031faf5ff94463e660d

Patch Set 1 #

Patch Set 2 : . #

Total comments: 3

Patch Set 3 : as sky #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -0 lines) Patch
A sky/examples/raw/painting.dart View 1 2 1 chunk +91 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Matt Perry
5 years, 6 months ago (2015-06-18 17:59:51 UTC) #2
Matt Perry
5 years, 6 months ago (2015-06-18 18:04:42 UTC) #4
Hixie
lgtm https://codereview.chromium.org/1188823008/diff/20001/sky/examples/raw/painting.dart File sky/examples/raw/painting.dart (right): https://codereview.chromium.org/1188823008/diff/20001/sky/examples/raw/painting.dart#newcode5 sky/examples/raw/painting.dart:5: import 'dart:sky'; as sky
5 years, 6 months ago (2015-06-18 18:09:32 UTC) #6
Matt Perry
https://codereview.chromium.org/1188823008/diff/20001/sky/examples/raw/painting.dart File sky/examples/raw/painting.dart (right): https://codereview.chromium.org/1188823008/diff/20001/sky/examples/raw/painting.dart#newcode5 sky/examples/raw/painting.dart:5: import 'dart:sky'; On 2015/06/18 18:09:32, Hixie wrote: > as ...
5 years, 6 months ago (2015-06-18 18:12:02 UTC) #7
Matt Perry
Committed patchset #3 (id:40001) manually as 85a6d0ebf169214bb20b8031faf5ff94463e660d (presubmit successful).
5 years, 6 months ago (2015-06-18 18:20:00 UTC) #8
Hixie
5 years, 6 months ago (2015-06-18 18:20:37 UTC) #9
Message was sent while issue was closed. 
https://codereview.chromium.org/1188823008/diff/20001/sky/examples/raw/painti...
File sky/examples/raw/painting.dart (right):

https://codereview.chromium.org/1188823008/diff/20001/sky/examples/raw/painti...
sky/examples/raw/painting.dart:5: import 'dart:sky';
On 2015/06/18 at 18:12:02, Matt Perry wrote:
> On 2015/06/18 18:09:32, Hixie wrote:
> > as sky
> 
> why?

sorry, I thought I'd deleted this comment. Ignore me.

Powered by Google App Engine
This is Rietveld 408576698