chrome/browser/metrics/chrome_stability_metrics_provider.cc - Issue 1188823002: [MemoryPressure] Move chrome/browser/chromeos/* to chrome/browser/memory/*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_stability_metrics_provider.cc

Issue 1188823002: [MemoryPressure] Move chrome/browser/chromeos/* to chrome/browser/memory/*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/memory/oom_priority_manager_chromeos.cc ('K') | « chrome/browser/memory/system_memory_stats_recorder_chromeos.cc ('k') | chrome/browser/ui/views/sad_tab_view.cc » ('j') | chrome/chrome_browser.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chrome_stability_metrics_provider.cc

diff --git a/chrome/browser/metrics/chrome_stability_metrics_provider.cc b/chrome/browser/metrics/chrome_stability_metrics_provider.cc

index 6968d4001159f0121029f985a6dc1919c0637112..a26d263d3f6913906dcaef38f4e92358f05fdc64 100644

--- a/chrome/browser/metrics/chrome_stability_metrics_provider.cc

+++ b/chrome/browser/metrics/chrome_stability_metrics_provider.cc

@@ -37,7 +37,7 @@

#endif

#if defined(OS_CHROMEOS)

-#include "chrome/browser/chromeos/memory/system_memory_stats_recorder.h"

+#include "chrome/browser/memory/system_memory_stats_recorder.h"

#endif

namespace {

@@ -302,10 +302,10 @@ void ChromeStabilityMetricsProvider::LogRendererCrash(

UMA_HISTOGRAM_ENUMERATION("BrowserRenderProcessHost.ChildKills.OOM",

was_extension_process ? 2 : 1,

3);

- chromeos::RecordMemoryStats(

- was_extension_process ?

- chromeos::RECORD_MEMORY_STATS_EXTENSIONS_OOM_KILLED :

- chromeos::RECORD_MEMORY_STATS_CONTENTS_OOM_KILLED);

+ memory::RecordMemoryStats(

+ was_extension_process

+ ? memory::RECORD_MEMORY_STATS_EXTENSIONS_OOM_KILLED

+ : memory::RECORD_MEMORY_STATS_CONTENTS_OOM_KILLED);

#endif

} else if (status == base::TERMINATION_STATUS_STILL_RUNNING) {

UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.DisconnectedAlive",