Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Side by Side Diff: cc/texture_layer_impl.cc

Issue 11888010: Cosmetic cleanup to texture_layer mailboxes. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebase Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/texture_layer_impl.h ('k') | cc/texture_layer_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/texture_layer_impl.h" 5 #include "cc/texture_layer_impl.h"
6 6
7 #include "base/stringprintf.h" 7 #include "base/stringprintf.h"
8 #include "cc/layer_tree_impl.h" 8 #include "cc/layer_tree_impl.h"
9 #include "cc/quad_sink.h" 9 #include "cc/quad_sink.h"
10 #include "cc/renderer.h" 10 #include "cc/renderer.h"
(...skipping 18 matching lines...) Expand all
29 m_vertexOpacity[3] = 1.0f; 29 m_vertexOpacity[3] = 1.0f;
30 } 30 }
31 31
32 TextureLayerImpl::~TextureLayerImpl() 32 TextureLayerImpl::~TextureLayerImpl()
33 { 33 {
34 if (m_externalTextureResource) { 34 if (m_externalTextureResource) {
35 DCHECK(m_usesMailbox); 35 DCHECK(m_usesMailbox);
36 ResourceProvider* provider = layerTreeImpl()->resource_provider(); 36 ResourceProvider* provider = layerTreeImpl()->resource_provider();
37 provider->deleteResource(m_externalTextureResource); 37 provider->deleteResource(m_externalTextureResource);
38 } 38 }
39 if (m_hasPendingMailbox && !m_pendingMailboxName.empty()) 39 if (m_hasPendingMailbox)
40 m_pendingMailboxReleaseCallback.Run(0); 40 m_pendingTextureMailbox.RunReleaseCallback(0);
41 } 41 }
42 42
43 void TextureLayerImpl::setTextureMailbox(const std::string& mailboxName, const b ase::Callback<void(unsigned)>& releaseCallback) 43 void TextureLayerImpl::setTextureMailbox(const TextureMailbox& mailbox)
44 { 44 {
45 DCHECK(m_usesMailbox); 45 DCHECK(m_usesMailbox);
46 // Same mailbox name was commited, nothing to do. 46 // Same mailbox name was commited, nothing to do.
47 if (m_pendingMailboxName.compare(mailboxName) == 0) 47 if (m_pendingTextureMailbox.Equals(mailbox))
48 return; 48 return;
49 // Two commits without a draw, ack the previous mailbox. 49 // Two commits without a draw, ack the previous mailbox.
50 if (m_hasPendingMailbox && !m_pendingMailboxReleaseCallback.is_null()) 50 if (m_hasPendingMailbox)
51 m_pendingMailboxReleaseCallback.Run(0); 51 m_pendingTextureMailbox.RunReleaseCallback(0);
52 52
53 m_pendingMailboxName = mailboxName; 53 m_pendingTextureMailbox = mailbox;
54 m_hasPendingMailbox = true; 54 m_hasPendingMailbox = true;
55 m_pendingMailboxReleaseCallback = releaseCallback;
56 } 55 }
57 56
58 void TextureLayerImpl::willDraw(ResourceProvider* resourceProvider) 57 void TextureLayerImpl::willDraw(ResourceProvider* resourceProvider)
59 { 58 {
60 if (!m_usesMailbox) { 59 if (!m_usesMailbox) {
61 if (!m_textureId) 60 if (!m_textureId)
62 return; 61 return;
63 DCHECK(!m_externalTextureResource); 62 DCHECK(!m_externalTextureResource);
64 m_externalTextureResource = resourceProvider->createResourceFromExternal Texture(m_textureId); 63 m_externalTextureResource = resourceProvider->createResourceFromExternal Texture(m_textureId);
65 return; 64 return;
66 } 65 }
67 66
68 if (!m_hasPendingMailbox) 67 if (!m_hasPendingMailbox)
69 return; 68 return;
70 69
71 if (m_externalTextureResource) { 70 if (m_externalTextureResource) {
72 resourceProvider->deleteResource(m_externalTextureResource); 71 resourceProvider->deleteResource(m_externalTextureResource);
73 m_externalTextureResource = 0; 72 m_externalTextureResource = 0;
74 } 73 }
75 if (!m_pendingMailboxName.empty()) 74 if (!m_pendingTextureMailbox.IsEmpty())
76 m_externalTextureResource = resourceProvider->createResourceFromTextureM ailbox(m_pendingMailboxName, m_pendingMailboxReleaseCallback); 75 m_externalTextureResource = resourceProvider->createResourceFromTextureM ailbox(m_pendingTextureMailbox);
77 m_hasPendingMailbox = false; 76 m_hasPendingMailbox = false;
78 } 77 }
79 78
80 void TextureLayerImpl::appendQuads(QuadSink& quadSink, AppendQuadsData& appendQu adsData) 79 void TextureLayerImpl::appendQuads(QuadSink& quadSink, AppendQuadsData& appendQu adsData)
81 { 80 {
82 if (!m_externalTextureResource) 81 if (!m_externalTextureResource)
83 return; 82 return;
84 83
85 SharedQuadState* sharedQuadState = quadSink.useSharedQuadState(createSharedQ uadState()); 84 SharedQuadState* sharedQuadState = quadSink.useSharedQuadState(createSharedQ uadState());
86 appendDebugBorderQuad(quadSink, sharedQuadState, appendQuadsData); 85 appendDebugBorderQuad(quadSink, sharedQuadState, appendQuadsData);
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 { 134 {
136 return "TextureLayer"; 135 return "TextureLayer";
137 } 136 }
138 137
139 bool TextureLayerImpl::canClipSelf() const 138 bool TextureLayerImpl::canClipSelf() const
140 { 139 {
141 return true; 140 return true;
142 } 141 }
143 142
144 } // namespace cc 143 } // namespace cc
OLDNEW
« no previous file with comments | « cc/texture_layer_impl.h ('k') | cc/texture_layer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698