Differentiate invisible cursor mode and disabled mouse events mode.

Differentiate invisible cursor mode and disabled mouse events mode.

I made the cursor visibility and the mouse events enable state work as follows.
- Typing keys just hides the cursor and mouse events are not disabled (mouse hover state is not cleared)
- Scrolling a web page when the cursor is invisible disables mouse events.
- Touch events disable mouse events.

BUG=154979
TBR=jln@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180528

[mazda, 2013-01-16 22:43:47]

Could you review this change?

oshima: cursor related changes
jam: content changes

Thanks,

[jam, 2013-01-17 00:50:53]

On 2013/01/16 22:43:47, mazda wrote:
> Could you review this change?
> 
> oshima: cursor related changes
> jam: content changes
> 
> Thanks,

lgtm for everything in content other than the _aura files. adding ben to look at
those, since he's more famiilar with that+ash+views

[Ben Goodger (Google), 2013-01-17 18:49:17]

content aura stuff lgtm

[oshima, 2013-01-17 18:57:02]

https://codereview.chromium.org/11888003/diff/21002/ash/wm/window_manager_uni...
File ash/wm/window_manager_unittest.cc (right):

https://codereview.chromium.org/11888003/diff/21002/ash/wm/window_manager_uni...
ash/wm/window_manager_unittest.cc:724: false);
can you use event generator?

[mazda, 2013-01-18 20:34:54]

Please take another look.

https://codereview.chromium.org/11888003/diff/21002/ash/wm/window_manager_uni...
File ash/wm/window_manager_unittest.cc (right):

https://codereview.chromium.org/11888003/diff/21002/ash/wm/window_manager_uni...
ash/wm/window_manager_unittest.cc:724: false);
On 2013/01/17 18:57:02, oshima wrote:
> can you use event generator?

Rewrote tests using EventGenerator. Thanks.

[oshima, 2013-01-18 21:59:56]

https://codereview.chromium.org/11888003/diff/32001/ash/wm/window_manager_uni...
File ash/wm/window_manager_unittest.cc (right):

https://codereview.chromium.org/11888003/diff/32001/ash/wm/window_manager_uni...
ash/wm/window_manager_unittest.cc:649: aura::test::EventGenerator
generator(root_window, window.get());
You should be able to use AshTestBase::GetEventGenerater()

https://codereview.chromium.org/11888003/diff/32001/ash/wm/window_manager_uni...
ash/wm/window_manager_unittest.cc:705: aura::test::EventGenerator
generator(root_window, window.get());
ditto

[mazda, 2013-01-18 22:44:38]

https://codereview.chromium.org/11888003/diff/32001/ash/wm/window_manager_uni...
File ash/wm/window_manager_unittest.cc (right):

https://codereview.chromium.org/11888003/diff/32001/ash/wm/window_manager_uni...
ash/wm/window_manager_unittest.cc:649: aura::test::EventGenerator
generator(root_window, window.get());
On 2013/01/18 21:59:56, oshima wrote:
> You should be able to use AshTestBase::GetEventGenerater()

Done.

https://codereview.chromium.org/11888003/diff/32001/ash/wm/window_manager_uni...
ash/wm/window_manager_unittest.cc:705: aura::test::EventGenerator
generator(root_window, window.get());
On 2013/01/18 21:59:56, oshima wrote:
> ditto

Done.

[oshima, 2013-01-18 22:49:17]

lgtm

[mazda, 2013-01-18 22:57:09]

+sky
Could you do an OWNERS review for ash and ui/views?

[sky, 2013-01-18 23:41:31]

LGTM

[commit-bot: I haz the power, 2013-01-19 00:29:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/11888003/43002

[commit-bot: I haz the power, 2013-01-19 00:29:18]

Presubmit check for 11888003-43002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/common/view_messages.h

Presubmit checks took 1.6s to calculate.

[mazda, 2013-01-19 00:35:23]

+jln,
Could you review content/common/view_messages.h?

[jln (very slow on Chromium), 2013-01-22 23:54:21]

https://codereview.chromium.org/11888003/diff/43002/content/common/view_messa...
File content/common/view_messages.h (right):

https://codereview.chromium.org/11888003/diff/43002/content/common/view_messa...
content/common/view_messages.h:1834: gfx::Vector2d /* offset */)
Do you think you'll ever need to process offset ?

That's where this review should focus, so if you don't use it for now, would you
mind not taking this parameter at the moment ? Or is there a good reason to
freeze this interface?

[mazda, 2013-01-23 01:42:00]

On 2013/01/22 23:54:21, Julien Tinnes wrote:
>
https://codereview.chromium.org/11888003/diff/43002/content/common/view_messa...
> File content/common/view_messages.h (right):
> 
>
https://codereview.chromium.org/11888003/diff/43002/content/common/view_messa...
> content/common/view_messages.h:1834: gfx::Vector2d /* offset */)
> Do you think you'll ever need to process offset ?
> 
> That's where this review should focus, so if you don't use it for now, would
you
> mind not taking this parameter at the moment ? Or is there a good reason to
> freeze this interface?

I added the offset parameter just because the interface seems more natural to
have it but I don't have plan to use it for now, so I'm totally fine with
removing it.

jam,
Is it OK to remove the offset parameter from
RenderWidgetHostViewPort::ScrollOffsetChanged?

[mazda, 2013-01-24 01:16:59]

John,
I removed the offset parameter from RenderWidgetHostPort::ScrollOffsetChanged
and other related functions per suggestion of Julien.
Please take another look.

[mazda, 2013-01-28 21:02:47]

jam: ping?

[James Cook, 2013-02-01 19:16:59]

On 2013/01/28 21:02:47, mazda wrote:
> jam: ping?

Did you want a second L G T M from jam?

[mazda, 2013-02-04 18:26:39]

James,
I chatted with John and he said no need L G T M again.

Julien,
Could you take another look?

[zel, 2013-02-04 21:16:41]

LGTM

[jln (very slow on Chromium), 2013-02-04 22:09:32]

LGTM