Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1188793004: RegExp: Remove bogus assumptions about case independence and Latin1 (Closed)

Created:
5 years, 6 months ago by Erik Corry Chromium.org
Modified:
5 years, 6 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

RegExp: Remove bogus assumptions about case independence and Latin1 Tests are already there in mjsuint/regress/regress-latin-1.js R=yangguo@chromium.org BUG=v8:3550 LOG=n Committed: https://crrev.com/d96e688dc9b108d96d8edadb24892007b0d2224a Cr-Commit-Position: refs/heads/master@{#29068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -20 lines) Patch
M src/jsregexp.cc View 4 chunks +23 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Erik Corry Chromium.org
5 years, 6 months ago (2015-06-16 17:35:19 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1188793004/1
5 years, 6 months ago (2015-06-16 17:59:07 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-16 19:25:26 UTC) #5
Yang
On 2015/06/16 19:25:26, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 6 months ago (2015-06-17 06:10:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1188793004/1
5 years, 6 months ago (2015-06-17 07:21:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 07:23:01 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 07:23:18 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d96e688dc9b108d96d8edadb24892007b0d2224a
Cr-Commit-Position: refs/heads/master@{#29068}

Powered by Google App Engine
This is Rietveld 408576698