content/browser/devtools/devtools_frame_trace_recorder.h - Issue 1188773005: DevTools: fix concurrency problems in DevToolsFrameTraceRecorder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_frame_trace_recorder.h

Issue 1188773005: DevTools: fix concurrency problems in DevToolsFrameTraceRecorder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/devtools/devtools_frame_trace_recorder.h

diff --git a/content/browser/devtools/devtools_frame_trace_recorder.h b/content/browser/devtools/devtools_frame_trace_recorder.h

index 88c4311b852543c87940a5bed8cecc5c5e33cc13..ed57ed0fcd33cb32cfc2509a809f41b6b9cd3eed 100644

--- a/content/browser/devtools/devtools_frame_trace_recorder.h

+++ b/content/browser/devtools/devtools_frame_trace_recorder.h

@@ -27,7 +27,7 @@ class DevToolsFrameTraceRecorder {

const cc::CompositorFrameMetadata& frame_metadata);

private:

- base::WeakPtr<DevToolsFrameTraceRecorderData> last_event_data_;

+ scoped_refptr<DevToolsFrameTraceRecorderData> pending_frame_data_;

DISALLOW_COPY_AND_ASSIGN(DevToolsFrameTraceRecorder);

};

« no previous file with comments | « base/trace_event/trace_event.h ('k') | content/browser/devtools/devtools_frame_trace_recorder.cc » ('j') | no next file with comments »