Source/core/html/forms/CheckboxInputType.cpp - Issue 1188763002: Click event should be fired before change events for checkbox and radio button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/CheckboxInputType.cpp

Issue 1188763002: Click event should be fired before change events for checkbox and radio button. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/radio-checkbox-events-order.html ('K') | « Source/core/html/HTMLInputElement.cpp ('k') | Source/core/html/forms/RadioInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/forms/CheckboxInputType.cpp

diff --git a/Source/core/html/forms/CheckboxInputType.cpp b/Source/core/html/forms/CheckboxInputType.cpp

index db0555974f4fcfcc75adda79802acdc9e9a90e10..b6a4d57a2aef6acda04cac81be90aadcb364c730 100644

--- a/Source/core/html/forms/CheckboxInputType.cpp

+++ b/Source/core/html/forms/CheckboxInputType.cpp

@@ -91,6 +91,8 @@ void CheckboxInputType::didDispatchClick(Event* event, const ClickHandlingState&

if (event->defaultPrevented() || event->defaultHandled()) {

element().setIndeterminate(state.indeterminate);

element().setChecked(state.checked);

+ } else {

+ element().dispatchChangeEventIfNeeded();

}

// The work we did in willDispatchClick was default handling.

« LayoutTests/fast/forms/radio-checkbox-events-order.html ('K') | « Source/core/html/HTMLInputElement.cpp ('k') | Source/core/html/forms/RadioInputType.cpp » ('j') | no next file with comments »