Source/core/html/HTMLInputElement.h - Issue 1188763002: Click event should be fired before change events for checkbox and radio button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.h

Issue 1188763002: Click event should be fired before change events for checkbox and radio button. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/radio-checkbox-events-order.html ('K') | « LayoutTests/fast/forms/radio/radio-group-keyboard-change-event-expected.txt ('k') | Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLInputElement.h

diff --git a/Source/core/html/HTMLInputElement.h b/Source/core/html/HTMLInputElement.h

index d1a05aaa9ff18daa018a3f5fbc9461e77a31b22d..e3b781409e55e6755da5f0603c3d69555f4ffc61 100644

--- a/Source/core/html/HTMLInputElement.h

+++ b/Source/core/html/HTMLInputElement.h

@@ -96,6 +96,7 @@ public:

bool checked() const { return m_isChecked; }

void setChecked(bool, TextFieldEventBehavior = DispatchNoEvent);

+ void dispatchChangeEventIfNeeded();

// 'indeterminate' is a state independent of the checked state that causes the control to draw in a way that hides the actual state.

bool indeterminate() const { return m_isIndeterminate; }