media: Fix mojo pipeline integration tests.

media: Fix mojo pipeline integration tests.

Use NullVideoSink instead of the dummy implementation to regularly trigger video
rendering.

R=dalecurtis@chromium.org
BUG=440850, 500812
TEST=Mojo pipeline integration test passes with mojo_runner:
out/GN/mojo_runner mojo:media_test

Committed: https://crrev.com/648a58d63f3db14c906c925fa4bc88fef3e168e6
Cr-Commit-Position: refs/heads/master@{#334694}

[xhwang, 2015-06-16 05:01:48]

PTAL

[DaleCurtis, 2015-06-16 16:24:44]

lgtm % q

https://codereview.chromium.org/1188753002/diff/20001/media/media.gyp
File media/media.gyp (right):

https://codereview.chromium.org/1188753002/diff/20001/media/media.gyp#newcode333
media/media.gyp:333: 'base/null_video_sink.cc',
Why the move back? Do the mojo tests not use test_support?

https://codereview.chromium.org/1188753002/diff/20001/media/mojo/services/ren...
File media/mojo/services/renderer_config_default.cc (right):

https://codereview.chromium.org/1188753002/diff/20001/media/mojo/services/ren...
media/mojo/services/renderer_config_default.cc:89: new NullVideoSink(false,
base::TimeDelta::FromMilliseconds(30),
FromSecondsD(1.0 / 60) is what I used elsewhere.

[xhwang, 2015-06-16 17:16:17]

comments addressed

[xhwang, 2015-06-16 17:16:57]

Thanks for the comments.

https://codereview.chromium.org/1188753002/diff/20001/media/media.gyp
File media/media.gyp (right):

https://codereview.chromium.org/1188753002/diff/20001/media/media.gyp#newcode333
media/media.gyp:333: 'base/null_video_sink.cc',
On 2015/06/16 16:24:44, DaleCurtis wrote:
> Why the move back? Do the mojo tests not use test_support?

This is used by DefaultRendererConfig, which is part of our default
implementation (not a test).

https://codereview.chromium.org/1188753002/diff/20001/media/mojo/services/ren...
File media/mojo/services/renderer_config_default.cc (right):

https://codereview.chromium.org/1188753002/diff/20001/media/mojo/services/ren...
media/mojo/services/renderer_config_default.cc:89: new NullVideoSink(false,
base::TimeDelta::FromMilliseconds(30),
On 2015/06/16 16:24:44, DaleCurtis wrote:
> FromSecondsD(1.0 / 60) is what I used elsewhere.

Done.

[xhwang, 2015-06-16 17:27:10]

On 2015/06/16 17:16:57, xhwang wrote:
> Thanks for the comments.
> 
> https://codereview.chromium.org/1188753002/diff/20001/media/media.gyp
> File media/media.gyp (right):
> 
>
https://codereview.chromium.org/1188753002/diff/20001/media/media.gyp#newcode333
> media/media.gyp:333: 'base/null_video_sink.cc',
> On 2015/06/16 16:24:44, DaleCurtis wrote:
> > Why the move back? Do the mojo tests not use test_support?
> 
> This is used by DefaultRendererConfig, which is part of our default
> implementation (not a test).
> 
>
https://codereview.chromium.org/1188753002/diff/20001/media/mojo/services/ren...
> File media/mojo/services/renderer_config_default.cc (right):
> 
>
https://codereview.chromium.org/1188753002/diff/20001/media/mojo/services/ren...
> media/mojo/services/renderer_config_default.cc:89: new NullVideoSink(false,
> base::TimeDelta::FromMilliseconds(30),
> On 2015/06/16 16:24:44, DaleCurtis wrote:
> > FromSecondsD(1.0 / 60) is what I used elsewhere.
> 
> Done.

dalecurtis: Do you want to take another look before I CQ?

[DaleCurtis, 2015-06-16 17:47:38]

Ah, no lgtm then.

[xhwang, 2015-06-16 18:13:42]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2015-06-16 18:15:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1188753002/40001

[commit-bot: I haz the power, 2015-06-16 18:49:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-16 18:49:41]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xhwang, 2015-06-16 19:27:58]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2015-06-16 19:27:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1188753002/#ps60001
(title: "MEDIA_EXPORT")

[commit-bot: I haz the power, 2015-06-16 19:29:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1188753002/60001

[commit-bot: I haz the power, 2015-06-16 21:08:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-06-16 21:09:12]

Patchset 4 (id:??) landed as
https://crrev.com/648a58d63f3db14c906c925fa4bc88fef3e168e6
Cr-Commit-Position: refs/heads/master@{#334694}