ui/base/ui_base_switches.h - Issue 1188713007: Moved --top-chrome-md command line switch from chrome_switches to ui_base_switches.

Side by Side Diff: ui/base/ui_base_switches.h

Issue 1188713007: Moved --top-chrome-md command line switch from chrome_switches to ui_base_switches. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved material_design_controller to ui/base/resource/material_design/. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/app/generated_resources.grd ('K') | « ui/base/ui_base.gyp ('k') | ui/base/ui_base_switches.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Defines all the command-line switches used by ui/base.	5 // Defines all the command-line switches used by ui/base.

6	6

7 #ifndef UI_BASE_UI_BASE_SWITCHES_H_	7 #ifndef UI_BASE_UI_BASE_SWITCHES_H_

8 #define UI_BASE_UI_BASE_SWITCHES_H_	8 #define UI_BASE_UI_BASE_SWITCHES_H_

9	9

10 #include "base/compiler_specific.h"	10 #include "base/compiler_specific.h"

(...skipping 11 matching lines...) Expand all Loading...
22 UI_BASE_EXPORT extern const char kDisableIconNtp[];	22 UI_BASE_EXPORT extern const char kDisableIconNtp[];

23 UI_BASE_EXPORT extern const char kDisableTouchAdjustment[];	23 UI_BASE_EXPORT extern const char kDisableTouchAdjustment[];

24 UI_BASE_EXPORT extern const char kDisableTouchDragDrop[];	24 UI_BASE_EXPORT extern const char kDisableTouchDragDrop[];

25 UI_BASE_EXPORT extern const char kDisableTouchEditing[];	25 UI_BASE_EXPORT extern const char kDisableTouchEditing[];

26 UI_BASE_EXPORT extern const char kDisableTouchFeedback[];	26 UI_BASE_EXPORT extern const char kDisableTouchFeedback[];

27 UI_BASE_EXPORT extern const char kEnableIconNtp[];	27 UI_BASE_EXPORT extern const char kEnableIconNtp[];

28 UI_BASE_EXPORT extern const char kEnableLinkDisambiguationPopup[];	28 UI_BASE_EXPORT extern const char kEnableLinkDisambiguationPopup[];

29 UI_BASE_EXPORT extern const char kEnableTouchDragDrop[];	29 UI_BASE_EXPORT extern const char kEnableTouchDragDrop[];

30 UI_BASE_EXPORT extern const char kEnableTouchEditing[];	30 UI_BASE_EXPORT extern const char kEnableTouchEditing[];

31 UI_BASE_EXPORT extern const char kLang[];	31 UI_BASE_EXPORT extern const char kLang[];

	32

	33 #if defined(ENABLE_TOPCHROME_MD)

	34 UI_BASE_EXPORT extern const char kTopChromeMD[];

	35 UI_BASE_EXPORT extern const char kTopChromeMDMaterial[];

	36 UI_BASE_EXPORT extern const char kTopChromeMDMaterialHybrid[];

	37 UI_BASE_EXPORT extern const char kTopChromeMDNonMaterial[];
	Dan Beam 2015/06/24 21:55:10 I'm trying to combine MD-related flags. Why do we I'm trying to combine MD-related flags. Why do we need 4 for this? tdanderson 2015/06/25 16:48:48 As discussed offline, this is needed for our use c Show quoted text On 2015/06/24 21:55:10, Dan Beam wrote: > I'm trying to combine MD-related flags. Why do we need 4 for this? As discussed offline, this is needed for our use case of switching between non-material, material, and hybrid layouts at runtime. Dan Beam 2015/06/25 17:05:35 Yeah, I understand now why you need them. Do you Show quoted text On 2015/06/25 16:48:48, tdanderson wrote: > On 2015/06/24 21:55:10, Dan Beam wrote: > > I'm trying to combine MD-related flags. Why do we need 4 for this? > > As discussed offline, this is needed for our use case of switching between > non-material, material, and hybrid layouts at runtime. Yeah, I understand now why you need them. Do you think we could add doc comments here explaining the differences? I think having 4 flags with the same prefix is kind of uncommon. This I arguably an easier spot than in some far away .grd after finding which IDS_* that corresponds to which flag (if those even exist for this). bruthig 2015/06/25 17:49:49 As is the convention for these switches, the docum Show quoted text On 2015/06/25 17:05:35, Dan Beam wrote: > On 2015/06/25 16:48:48, tdanderson wrote: > > On 2015/06/24 21:55:10, Dan Beam wrote: > > > I'm trying to combine MD-related flags. Why do we need 4 for this? > > > > As discussed offline, this is needed for our use case of switching between > > non-material, material, and hybrid layouts at runtime. > > Yeah, I understand now why you need them. Do you think we could add doc > comments here explaining the differences? I think having 4 flags with the same > prefix is kind of uncommon. This I arguably an easier spot than in some far > away .grd after finding which IDS_* that corresponds to which flag (if those > even exist for this). As is the convention for these switches, the documentation is in the .cc file. As for having switches having the same prefix, this may not seem common when looking at the different _switches.h files because most aren't of the MULTI_VALUE_TYPE. I took a look at the different Experiment::Choice arrays in about_flags.cc and some examples of this convention are: kTouchEventsChoices, kMarkNonSecureAsChoices, kExtensionContentVerificationChoices, kExtensionContentVerificationChoices. I'm open to suggestions but I feel like it is currently following conventions. Dan Beam* 2015/06/25 18:11:43 you're right and I just probably haven't seen that Show quoted text On 2015/06/25 17:49:49, bruthig wrote: > On 2015/06/25 17:05:35, Dan Beam wrote: > > On 2015/06/25 16:48:48, tdanderson wrote: > > > On 2015/06/24 21:55:10, Dan Beam wrote: > > > > I'm trying to combine MD-related flags. Why do we need 4 for this? > > > > > > As discussed offline, this is needed for our use case of switching between > > > non-material, material, and hybrid layouts at runtime. > > > > Yeah, I understand now why you need them. Do you think we could add doc > > comments here explaining the differences? I think having 4 flags with the > same > > prefix is kind of uncommon. This I arguably an easier spot than in some far > > away .grd after finding which IDS_* that corresponds to which flag (if those > > even exist for this). > > As is the convention for these switches, the documentation is in the .cc file. > > As for having switches having the same prefix, this may not seem common when > looking at the different *_switches.h files because most aren't of the > MULTI_VALUE_TYPE. I took a look at the different Experiment::Choice arrays in > about_flags.cc and some examples of this convention are: kTouchEventsChoices, > kMarkNonSecureAsChoices, kExtensionContentVerificationChoices, > kExtensionContentVerificationChoices. > > I'm open to suggestions but I feel like it is currently following conventions. you're right and I just probably haven't seen that many MULTI_VALUE_TYPE. good enough for me, sorry for the noise.
	38 #endif // defind(ENABLE_TOPCHROME_MD)

	39

32 UI_BASE_EXPORT extern const char kViewerConnect[];	40 UI_BASE_EXPORT extern const char kViewerConnect[];

33	41

34 } // namespace switches	42 } // namespace switches

35	43

36 #endif // UI_BASE_UI_BASE_SWITCHES_H_	44 #endif // UI_BASE_UI_BASE_SWITCHES_H_

OLD	NEW